From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: alexander.turenko@tarantool.org
Subject: [tarantool-patches] Re: [PATCH 1/1] wal: deprecate wal_max_rows in favour of wal_max_size
Date: Sat, 7 Sep 2019 15:59:40 +0200 [thread overview]
Message-ID: <e93fad8e-9c36-50f1-7b76-3e80f27df676@tarantool.org> (raw)
In-Reply-To: <e54b3c732963ec48edbe83b247bad92a0b54a262.1567864131.git.v.shpilevoy@tarantool.org>
Sorry, ignore it, please.
On 07/09/2019 15:51, Vladislav Shpilevoy wrote:
> wal_max_rows does not allow to properly limit size of WAL logs.
> A user would need to estimate size of each WAL row to do that.
> Now WAL supports option wal_max_size allowing to limit WAL size
> much more precise.
>
> Part of #3762
> ---
> Note: Based on branch 1.10. It should be pushed to 1.10 and cherry-picked to
> all > 1.10 and < master.
>
> Issue: https://github.com/tarantool/tarantool/issues/3762
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4282-box-cfg-rs-uuid
>
> src/box/lua/load_cfg.lua | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua
> index 77f57eb05..432a3374b 100644
> --- a/src/box/lua/load_cfg.lua
> +++ b/src/box/lua/load_cfg.lua
> @@ -291,6 +291,7 @@ local translate_cfg = {
> panic_on_snap_error = {'force_recovery', function (p) return not p end},
> panic_on_wal_error = {'force_recovery', function (p) return not p end},
> replication_source = {'replication'},
> + wal_max_rows = {'wal_max_size'},
> }
>
> -- Upgrade old config
>
prev parent reply other threads:[~2019-09-07 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 13:51 [tarantool-patches] " Vladislav Shpilevoy
2019-09-07 13:59 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e93fad8e-9c36-50f1-7b76-3e80f27df676@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/1] wal: deprecate wal_max_rows in favour of wal_max_size' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox