[tarantool-patches] Re: [PATCH 4/6] sql: enforce implicit type conversions

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the fixes! See 3 comments below.

> --- a/test/sql-tap/boundary1.test.lua
> +++ b/test/sql-tap/boundary1.test.lua
> @@ -7649,5 +7649,4 @@ test:do_execsql_test(
>      "boundary1-2.66.le.5",
>      "SELECT a FROM t1 WHERE rowid <= -9.22337303685477580800e+18 ORDER BY x",
>      {})
> -
>  test:finish_test(
1. Stray diff in boundary1.test.lua.

>>> diff --git a/test/sql-tap/boundary2.test.lua b/test/sql-tap/boundary2.test.lua
>>> index 3eaef75dc..be4b8750d 100755
>>> --- a/test/sql-tap/boundary2.test.lua
>>> +++ b/test/sql-tap/boundary2.test.lua
>>> @@ -1,6 +1,6 @@
>>>   #!/usr/bin/env tarantool
>>>   test = require("sqltester")
>>> -test:plan(3021)
>>> +test:plan(2965)
>>>     --!./tcltestrunner.lua
>>>   -- 2008 December 11
>>> @@ -7462,6 +7462,7 @@ test:do_execsql_test(
>>>       "SELECT a FROM t1 WHERE r > 9.22337303685477580800e+18 ORDER BY a DESC",
>>>       {})
>>>   +if false then
>>
>> 6. I thought you have removed all these 'if false'. Please, do it.
> 
> I did it in boundary3 test and forgot about this one. Fixed:

2. Sorry, still can be found in cast.test.lua.

Also stray empty lines on 526, 763.

3. if false in in3.test.lua.