From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: increment VIEW counter for tables within sub-select
Date: Mon, 3 Dec 2018 19:19:40 +0300 [thread overview]
Message-ID: <e6ab34cd-9be7-294f-f83d-70038d7e457f@tarantool.org> (raw)
In-Reply-To: <20181203150037.60513-1-korablev@tarantool.org>
Hi! Thanks for the patch!
The patch is ok, but please, apply this
diff:
diff --git a/src/box/alter.cc b/src/box/alter.cc
index eca217511..03ba68adc 100644
--- a/src/box/alter.cc
+++ b/src/box/alter.cc
@@ -1515,8 +1515,8 @@ update_view_references(struct Select *select, int update_value,
uint32_t space_id;
if (schema_find_id(BOX_SPACE_ID, 2, space_name,
strlen(space_name), &space_id) != 0) {
- sqlite3SrcListDelete(sql_get(), list);
- return -1;
+ sqlite3SrcListDelete(sql_get(), list);
+ return -1;
}
if (space_id == BOX_ID_NIL) {
if (! suppress_error) {
After it the patch LGTM.
next prev parent reply other threads:[~2018-12-03 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 15:00 [tarantool-patches] " Nikita Pettik
2018-12-03 16:19 ` Vladislav Shpilevoy [this message]
2018-12-14 10:34 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6ab34cd-9be7-294f-f83d-70038d7e457f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: increment VIEW counter for tables within sub-select' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox