Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org, alexander.turenko@tarantool.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] [PATCH v1 1/1] box: fix custom delimiter for telnet connection
Date: Thu, 21 Feb 2019 10:34:55 +0300	[thread overview]
Message-ID: <e61f08660a5010156c0bd940d07ba0d27828bf75.1550734259.git.kshcherbatov@tarantool.org> (raw)

Because test-run uses a console connection to run tests, the
actual string delimiter was the user-specified delimiter
delim + "\n".
Since telnet sends \r\n on line break, the updated expression
delim + "\n"could not be found in a sequence data+delim+"\r\n",
so delimiter feature did not work at all.
Added delim + "\r" check along with delim + "\n", that solves the
described problem and does not violate backward compatibility.

Closes #2027

https://github.com/tarantool/tarantool/tree/kshch/gh-2027-telnet-alternative-delimiter
https://github.com/tarantool/tarantool/issues/2027
---
 src/box/lua/console.lua | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/box/lua/console.lua b/src/box/lua/console.lua
index 028001127..bdedcb393 100644
--- a/src/box/lua/console.lua
+++ b/src/box/lua/console.lua
@@ -344,8 +344,9 @@ end
 -- Read command from connected client console.listen()
 --
 local function client_read(self)
-    local delim = self.delimiter .. "\n"
-    local buf = self.client:read(delim)
+    local delim_lf = self.delimiter .. "\n"
+    local delim_cr = self.delimiter .. "\r"
+    local buf = self.client:read({delimiter = {delim_lf, delim_cr}})
     if buf == nil then
         return nil
     elseif buf == "" then
@@ -355,7 +356,7 @@ local function client_read(self)
         return nil
     end
     -- remove trailing delimiter
-    return buf:sub(1, -#delim-1)
+    return buf:sub(1, -#delim_lf-1)
 end
 
 --
-- 
2.20.1

             reply	other threads:[~2019-02-21  7:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21  7:34 Kirill Shcherbatov [this message]
2019-03-05 13:43 ` [tarantool-patches] " Alexander Turenko
2019-03-05 14:41   ` Kirill Shcherbatov
2019-03-05 16:12     ` Alexander Turenko
2019-03-07 10:16 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e61f08660a5010156c0bd940d07ba0d27828bf75.1550734259.git.kshcherbatov@tarantool.org \
    --to=kshcherbatov@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH v1 1/1] box: fix custom delimiter for telnet connection' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox