From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Konstantin Osipov <kostja@tarantool.org>
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 0/2] Fix lost format on update operation
Date: Sat, 28 Apr 2018 12:29:24 +0300 [thread overview]
Message-ID: <e5d47ea2-da61-5eba-b681-2f7dfffb4676@tarantool.org> (raw)
In-Reply-To: <cover.1523031806.git.kshcherbatov@tarantool.org>
Now the patchset LGTM. Kostja, please, look at this.
On 06/04/2018 19:24, Kirill Shcherbatov wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gh-3051-lost-format-while-tuple-update
> Issue: https://github.com/tarantool/tarantool/issues/3051
>
> Kirill Shcherbatov (2):
> Fixed invalid check in lbox_tuple_transform.
> Fixed lost format on update and upsert operations.
>
> src/box/lua/tuple.c | 6 ++--
> src/box/memtx_tuple.cc | 1 +
> src/box/tuple.c | 42 ++++++++++++++++--------
> src/box/tuple.h | 6 +++-
> src/box/tuple_format.h | 5 ++-
> src/box/vy_stmt.c | 7 ++++
> src/box/vy_stmt.h | 9 +++++
> test/box/update.result | 85 ++++++++++++++++++++++++++++++++++++++++++++++++
> test/box/update.test.lua | 28 ++++++++++++++++
> 9 files changed, 171 insertions(+), 18 deletions(-)
>
prev parent reply other threads:[~2018-04-28 9:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 16:24 [tarantool-patches] " Kirill Shcherbatov
2018-04-06 16:24 ` [tarantool-patches] [PATCH v2 1/2] Fixed invalid check in lbox_tuple_transform Kirill Shcherbatov
2018-04-06 16:24 ` [tarantool-patches] [PATCH v2 2/2] Fixed lost format on update and upsert operations Kirill Shcherbatov
2018-04-08 13:56 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-10 10:23 ` Kirill Shcherbatov
2018-04-10 10:44 ` Vladislav Shpilevoy
2018-04-15 10:03 ` Kirill Shcherbatov
2018-04-15 13:18 ` Vladislav Shpilevoy
2018-04-16 7:47 ` Kirill Shcherbatov
2018-04-16 10:07 ` Vladislav Shpilevoy
2018-04-16 16:51 ` Kirill Shcherbatov
2018-04-16 17:14 ` Vladislav Shpilevoy
2018-04-18 12:28 ` Vladimir Davydov
2018-04-18 12:55 ` Kirill Shcherbatov
2018-04-22 15:15 ` Vladislav Shpilevoy
2018-04-28 6:56 ` Kirill Shcherbatov
2018-04-28 9:29 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d47ea2-da61-5eba-b681-2f7dfffb4676@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 0/2] Fix lost format on update operation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox