From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org, imun@tarantool.org,
korablev@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in update
Date: Wed, 5 Feb 2020 23:11:05 +0100 [thread overview]
Message-ID: <e53b4f77-ceb8-64b1-789e-b3fda1119077@tarantool.org> (raw)
In-Reply-To: <20200205110944.GA9833@atlas>
Hi!
On 05/02/2020 12:09, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/02/05 01:53]:
>> The patchset fixes float value truncation in
>> tuple/space:update/upsert. First commit fixes the actual issue,
>> but introduces another bug that a float value can be stored into a
>> field having double type in its format.
>
> Thanks for CCing. While I find the general idea of the series quite
> nice, I don't know why it's a priority.
It was assigned to a milestone, and the code still is in my
head's "cache" after JSON updates, so I decided to fix it.
> Did anyone actually complain?
Nobody so far. Just me.
> PS Would be best if you don't Cc/To me with the entire series next
> time, but @mention me on the list if you would like to get my review. I am
> reading all patches on the list anyway, no need to copy them to my inbox.
Ok, will do that next time.
next prev parent reply other threads:[~2020-02-05 22:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 22:53 Vladislav Shpilevoy
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 1/4] tuple: don't truncate float in :update() Vladislav Shpilevoy
2020-02-10 14:41 ` Nikita Pettik
2020-02-10 21:18 ` Vladislav Shpilevoy
2020-02-19 21:36 ` Nikita Pettik
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 2/4] tuple: pass tuple format to xrow_update_*_store() Vladislav Shpilevoy
2020-02-10 16:51 ` Nikita Pettik
2020-02-10 21:18 ` Vladislav Shpilevoy
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 3/4] tuple: allow xrow_update sizeof reserve more memory Vladislav Shpilevoy
2020-02-10 16:05 ` Nikita Pettik
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 4/4] tuple: use field type in update of a float/double Vladislav Shpilevoy
2020-02-10 16:16 ` Nikita Pettik
2020-02-10 21:18 ` Vladislav Shpilevoy
2020-02-05 11:09 ` [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in update Konstantin Osipov
2020-02-05 22:11 ` Vladislav Shpilevoy [this message]
2020-02-20 6:15 ` Kirill Yukhin
2020-02-20 13:27 ` Nikita Pettik
2020-02-20 20:30 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e53b4f77-ceb8-64b1-789e-b3fda1119077@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imun@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/4] Don'\''t truncate float in update' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox