Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, gorcunov@gmail.com,
	sergepetrenko@tarantool.org,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH msgpuck 2/2] Make MP_EXT mp_snprint() and mp_fprint() customizable
Date: Tue, 19 May 2020 22:48:47 +0200	[thread overview]
Message-ID: <e4e1e59c-01e4-1e54-6bea-08227c0d748c@tarantool.org> (raw)
In-Reply-To: <1b15d2ad18263ed060088aa4f7e105b574c07ffa.1589240001.git.v.shpilevoy@tarantool.org>

Changed some comments:

====================
diff --git a/msgpuck.h b/msgpuck.h
index a92f177..16d72d5 100644
--- a/msgpuck.h
+++ b/msgpuck.h
@@ -983,6 +983,9 @@ mp_vformat(char *data, size_t data_size, const char *format, va_list args);
  * a standard JSON, printing a MessagePack buffer, having MP_EXT
  * in it, may lead to an invalid JSON.
  *
+ * However MP_EXT may be printed differently in case a proper
+ * virtual serializer was installed. \sa mp_fprint_ext_f.
+ *
  * \param file - pointer to file (or NULL for stdout)
  * \param data - pointer to buffer containing msgpack object
  * \retval >=0 - the number of bytes printed
@@ -1011,7 +1014,11 @@ extern mp_fprint_ext_f mp_fprint_ext;
 
 /**
  * \brief Default MP_EXT serializer into a file. Skips the object,
- * ignores all the other arguments, and writes 'undefined'.
+ * ignores all the other arguments, and writes
+ *
+ *     (extension: type <type>, len <len>)
+ *
+ * \sa mp_fprint().
  */
 int
 mp_fprint_ext_default(FILE *file, const char **data, int depth);
@@ -1056,7 +1063,10 @@ extern mp_snprint_ext_f mp_snprint_ext;
 /**
  * \brief Default MP_EXT serializer into a string. Skips the
  * object, ignores all the other arguments, and prints
- * 'undefined'.
+ *
+ *     (extension: type <type>, len <len>)
+ *
+ * \sa mp_snprint().
  */
 int
 mp_snprint_ext_default(char *buf, int size, const char **data, int depth);

  reply	other threads:[~2020-05-19 20:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 23:46 [Tarantool-patches] [PATCH msgpuck 0/2] MP_EXT virtual serializer Vladislav Shpilevoy
2020-05-11 23:46 ` [Tarantool-patches] [PATCH msgpuck 1/2] Return recursion to mp_snprint() and mp_fprint() Vladislav Shpilevoy
2020-05-11 23:46 ` [Tarantool-patches] [PATCH msgpuck 2/2] Make MP_EXT mp_snprint() and mp_fprint() customizable Vladislav Shpilevoy
2020-05-19 20:48   ` Vladislav Shpilevoy [this message]
2020-05-14 21:26 ` [Tarantool-patches] [PATCH msgpuck 1.5/2] Provide more details at MP_EXT mp_fprint/snprint() Vladislav Shpilevoy
2020-05-19 12:14   ` Alexander Turenko
2020-05-19 20:48     ` Vladislav Shpilevoy
2020-05-18 15:18 ` [Tarantool-patches] [PATCH msgpuck 0/2] MP_EXT virtual serializer Serge Petrenko
2020-05-19  9:10   ` Cyrill Gorcunov
2020-05-21 18:23 ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4e1e59c-01e4-1e54-6bea-08227c0d748c@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH msgpuck 2/2] Make MP_EXT mp_snprint() and mp_fprint() customizable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox