From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Georgy Kirichenko <georgy@tarantool.org>,
tarantool-patches@dev.tarantool.org, kostja.osipov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval()
Date: Sun, 19 Jan 2020 18:32:45 +0100 [thread overview]
Message-ID: <e4bc4889-cec9-2256-c770-5a1d0e5a4218@tarantool.org> (raw)
In-Reply-To: <2144259.ElGaqSPkdT@localhost>
Hi! Thanks for the review!
On 17/01/2020 18:41, Georgy Kirichenko wrote:
> On Friday, 17 January 2020 00:54:23 MSK Vladislav Shpilevoy wrote:
>> box_process_call/eval() in the end check if there is an
>> active transaction. If there is, it is rolled back, and
>> an error is set.
>>
>> But rollback is not needed anymore, because anyway in
>> the end of the request the fiber is stopped, and its
>> not finished transaction is rolled back. Just setting
>> of the error is enough.
>
> Hi!
> Thanks for the patch, but I do not think that to remove an explicit rollback
> is a a good idea because of broken encapsulation - call and eval handlers
> should not rely on its execution context - a simple fiber, iproto fiber pool
> member or whatever else. Also I would like to mention that box_call and
> box_eval are members of the public api and it is not necessary that user will
> stop a fiber.
Functions box_call and box_eval don't exist. So I don't understand what you
are talking about.
Assume you talked about box_process_call/eval. In that case you are wrong -
they are not a part of the public API. They are always called from iproto.cc
only. Besides, we will need to remove ER_FUNCTION_TX_ACTIVE and all the other
txn stuff from them anyway after interactive transactions are ready.
next prev parent reply other threads:[~2020-01-19 17:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 21:54 [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak Vladislav Shpilevoy
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 1/3] fiber: unref fiber.storage via global Lua state Vladislav Shpilevoy
2020-01-17 7:30 ` Konstantin Osipov
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 2/3] fiber: destroy fiber.storage created by iproto Vladislav Shpilevoy
2020-01-16 22:00 ` Cyrill Gorcunov
2020-01-17 7:47 ` Konstantin Osipov
2020-01-17 8:06 ` Cyrill Gorcunov
2020-01-17 7:45 ` Konstantin Osipov
2020-01-19 17:32 ` Vladislav Shpilevoy
2020-01-20 7:22 ` Konstantin Osipov
2020-01-20 19:15 ` Georgy Kirichenko
2020-01-21 22:21 ` Vladislav Shpilevoy
2020-01-21 22:32 ` Konstantin Osipov
2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval() Vladislav Shpilevoy
2020-01-17 7:46 ` Konstantin Osipov
2020-01-17 7:47 ` Konstantin Osipov
2020-01-17 17:41 ` Georgy Kirichenko
2020-01-19 17:32 ` Vladislav Shpilevoy [this message]
2020-01-20 19:21 ` Georgy Kirichenko
2020-01-18 19:27 ` [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak Igor Munkin
2020-02-15 1:02 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4bc4889-cec9-2256-c770-5a1d0e5a4218@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=georgy@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox