From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] test: fix flaky replication/gh-* tests
Date: Wed, 27 Nov 2019 23:30:59 +0100 [thread overview]
Message-ID: <e475eb98-ad98-725d-fba9-e361cf262773@tarantool.org> (raw)
In-Reply-To: <20191126234926.qmjts444lttinxki@tkn_work_nb>
Hi!
On 27/11/2019 00:49, Alexander Turenko wrote:
> There are more such tests, let's check it youself:
>
> $ diff -u \
> <(grep -R cleanup_cluster test/replication/*.test.lua | cut -d: -f1 | sort -u) \
> <(grep -R rpl_master=default test/replication/*.test.lua | cut -d: -f1 | sort -u) \
> | grep ^[+-]test
>
> +test/replication/consistent.test.lua
This test is disabled. It makes no sense to change it now, if it
is broken anyway.
> +test/replication/errinj.test.lua
> +test/replication/transaction.test.lua
Yes, these ones lack cluster cleanup.
> +test/replication/gh-4402-info-errno.test.lua
> +test/replication/gh-4605-empty-password.test.lua
> +test/replication/gh-4606-admin-creds.test.lua
These three I fixed in my patch.
But whatever. Seems like you have already committed your
fix, so there is nothing to discuss.
prev parent reply other threads:[~2019-11-27 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 22:43 Vladislav Shpilevoy
2019-11-26 23:49 ` Alexander Turenko
2019-11-27 22:30 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e475eb98-ad98-725d-fba9-e361cf262773@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] test: fix flaky replication/gh-* tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox