From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH 08/11] vinyl: set quota timer period to 100 ms Date: Thu, 20 Sep 2018 12:34:13 +0300 [thread overview] Message-ID: <e38ef89f1beb4169bb5f4d0ebfeb2a4354493aa1.1537435404.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1537435404.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1537435404.git.vdavydov.dev@gmail.com> Currently, it's 1 second, which is OK for calculating watermark, but too long for throttling (think of latency of 1 seconds that would be introduced by throttling if such timeout were used). --- src/box/vy_quota.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/box/vy_quota.c b/src/box/vy_quota.c index 5f8c0618..def05aa2 100644 --- a/src/box/vy_quota.c +++ b/src/box/vy_quota.c @@ -43,18 +43,17 @@ #include "histogram.h" #include "trivia/util.h" -enum { - /** - * Time interval between successive updates of - * quota watermark and use rate, in seconds. - */ - VY_QUOTA_UPDATE_INTERVAL = 1, - /** - * Period of time over which the quota use rate - * is averaged, in seconds. - */ - VY_QUOTA_RATE_AVG_PERIOD = 5, -}; +/** + * Time interval between successive updates of quota watermark + * and use rate, in seconds. + */ +static const double VY_QUOTA_UPDATE_INTERVAL = 0.1; + +/** + * Period of time over which the quota use rate is averaged, + * in seconds. + */ +static const double VY_QUOTA_RATE_AVG_PERIOD = 5; /* * Until we dump anything, assume bandwidth to be 10 MB/s, @@ -106,7 +105,7 @@ vy_quota_timer_cb(ev_loop *loop, ev_timer *timer, int events) * Update the quota use rate with the new measurement. */ const double weight = 1 - exp(-VY_QUOTA_UPDATE_INTERVAL / - (double)VY_QUOTA_RATE_AVG_PERIOD); + VY_QUOTA_RATE_AVG_PERIOD); q->use_rate = (1 - weight) * q->use_rate + weight * q->use_curr / VY_QUOTA_UPDATE_INTERVAL; q->use_curr = 0; -- 2.11.0
next prev parent reply other threads:[~2018-09-20 9:34 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-20 9:34 [PATCH 00/11] vinyl: prepare for transaction throttling Vladimir Davydov 2018-09-20 9:34 ` [PATCH 01/11] vinyl: merge vy_quota_release and vy_quota_update_dump_bandwidth Vladimir Davydov 2018-09-20 9:34 ` [PATCH 02/11] vinyl: refactor quota use/unuse methods Vladimir Davydov 2018-09-20 9:34 ` [PATCH 03/11] vinyl: do not try to trigger dump if it is already in progress Vladimir Davydov 2018-09-20 9:34 ` [PATCH 04/11] vinyl: don't start quota timer until local recovery is complete Vladimir Davydov 2018-09-20 9:34 ` [PATCH 05/11] vinyl: add helper to start scheduler and enable quota on startup Vladimir Davydov 2018-09-25 23:22 ` [tarantool-patches] " Konstantin Osipov 2018-09-20 9:34 ` [PATCH 06/11] vinyl: zap vy_env::memory, read_threads, and write_threads Vladimir Davydov 2018-09-25 23:23 ` [tarantool-patches] " Konstantin Osipov 2018-09-20 9:34 ` [PATCH 07/11] vinyl: do not account zero dump bandwidth Vladimir Davydov 2018-09-25 23:24 ` [tarantool-patches] " Konstantin Osipov 2018-09-20 9:34 ` Vladimir Davydov [this message] 2018-09-20 9:34 ` [PATCH 09/11] vinyl: implement basic transaction throttling Vladimir Davydov 2018-09-20 9:34 ` [PATCH 10/11] vinyl: implement quota wait queue without fiber_cond Vladimir Davydov 2018-09-20 9:34 ` [PATCH 11/11] vinyl: split quota consumption rate limit into soft and hard Vladimir Davydov 2018-09-25 23:19 ` [tarantool-patches] Re: [PATCH 00/11] vinyl: prepare for transaction throttling Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e38ef89f1beb4169bb5f4d0ebfeb2a4354493aa1.1537435404.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH 08/11] vinyl: set quota timer period to 100 ms' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox