Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance
Date: Fri, 8 May 2020 14:16:28 +0300	[thread overview]
Message-ID: <e38be5b6-5f14-419b-bd6a-462ec4427247@tarantool.org> (raw)
In-Reply-To: <9ebb6d36-c3d1-0d81-ed83-5861c270a73c@tarantool.org>


08.05.2020 00:53, Vladislav Shpilevoy пишет:
> Hi! Thanks for the fixes!
>
>>>> @@ -429,36 +430,10 @@ test_run:cmd('set variable repl_source to "replica_anon1.listen"')
>>>>    box.cfg{replication=repl_source}
>>>>     | ---
>>>>     | ...
>>>> -
>>>> -test_run:cmd('switch default')
>>>> - | ---
>>>> - | - true
>>>> - | ...
>>>> -box.space.test:insert{2}
>>>> - | ---
>>>> - | - [2]
>>>> - | ...
>>>> -
>>>> -test_run:cmd('switch replica_anon1')
>>>> - | ---
>>>> - | - true
>>>> - | ...
>>>> --- Check that the new replica follows an anonymous one.
>>>> -test_run:wait_downstream(2, {status='follow'})
>>>> +test_run:wait_log('replica', 'ER_UNSUPPORTED: Anonymous replica does not support non.anonymous followers.', nil, 10)
>>> 2. Perhaps 'non-anonymous' instead of 'non.anonymous'?
>> Dot  matches anything, and I couldn't find a way to escape '-', it must be a special symbol of sorts.
>> So let it be 'non.anonymous'.
> I again forgot how regular expressions look in Lua. Yeah, sure then, '.' is fine.
> Talking of escape symbol - it is %

Didn't know that, thanks!


-- 
Serge Petrenko

  reply	other threads:[~2020-05-08 11:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 13:11 Serge Petrenko
2020-04-20 19:29 ` Cyrill Gorcunov
2020-04-28 20:55 ` Vladislav Shpilevoy
2020-05-06 10:08   ` Serge Petrenko
2020-05-06 21:51     ` Vladislav Shpilevoy
2020-05-07 10:33       ` Serge Petrenko
2020-05-07 21:53         ` Vladislav Shpilevoy
2020-05-08 11:16           ` Serge Petrenko [this message]
2020-05-10 19:43 ` Vladislav Shpilevoy
2020-05-15 14:37 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e38be5b6-5f14-419b-bd6a-462ec4427247@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox