From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2] test: cleanup box/net.box_call_blocks_gh-946
Date: Fri, 3 Jul 2020 17:23:26 +0300 [thread overview]
Message-ID: <e36a7ae2432664c03834f778e049b4bdb9782196.1593786047.git.avtikhon@tarantool.org> (raw)
Found issue with 'readahead limit is reached':
iproto iproto.cc:606 W> stopping input on connection fd 23, aka unix/:(socket), peer of unix/:(socket), readahead limit is reached
While the test doesn't check it. To fix the issue increased
'readahead' value.
Found issue at the tests running after the current test:
main/435/console/unix/: utils.c:1005 E> LuajitError: [string "function on_disconnect() disconnected = true ..."]:1: assign to undeclared variable 'disconnected'
Found that the root cause of the issue, that tests run on the same
worker, in this case function on_disconnected must be cleaned.
Also clean up of the test at its end improved.
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/cleanup_test_box_call_blocks
V1: https://lists.tarantool.org/pipermail/tarantool-patches/2020-June/018020.html
test/box/net.box_call_blocks_gh-946.result | 30 ++++++++++++++++++++
test/box/net.box_call_blocks_gh-946.test.lua | 12 ++++++++
2 files changed, 42 insertions(+)
diff --git a/test/box/net.box_call_blocks_gh-946.result b/test/box/net.box_call_blocks_gh-946.result
index 2f6d5fcf2..d9d868ce1 100644
--- a/test/box/net.box_call_blocks_gh-946.result
+++ b/test/box/net.box_call_blocks_gh-946.result
@@ -11,6 +11,12 @@ test_run:cmd('create server connecter with script = "box/proxy.lua"')
---
- true
...
+readahead = box.cfg.readahead
+---
+...
+box.cfg{readahead = 100 * 1024}
+---
+...
--
-- gh-946: long polling CALL blocks input
--
@@ -117,3 +123,27 @@ box.session.on_disconnect(on_disconnect) == on_disconnect
---
- true
...
+c:close()
+---
+...
+box.schema.user.revoke('guest', 'execute', 'function', 'fast_call')
+---
+...
+box.schema.user.revoke('guest', 'execute', 'function', 'long_call')
+---
+...
+box.schema.user.revoke('guest', 'execute', 'function', 'wait_signal')
+---
+...
+box.schema.func.drop('fast_call')
+---
+...
+box.schema.func.drop('long_call')
+---
+...
+box.schema.func.drop('wait_signal')
+---
+...
+box.cfg{readahead = readahead}
+---
+...
diff --git a/test/box/net.box_call_blocks_gh-946.test.lua b/test/box/net.box_call_blocks_gh-946.test.lua
index 541541eda..951919737 100644
--- a/test/box/net.box_call_blocks_gh-946.test.lua
+++ b/test/box/net.box_call_blocks_gh-946.test.lua
@@ -5,6 +5,9 @@ net = require('net.box')
test_run:cmd('create server connecter with script = "box/proxy.lua"')
+readahead = box.cfg.readahead
+box.cfg{readahead = 100 * 1024}
+
--
-- gh-946: long polling CALL blocks input
--
@@ -61,3 +64,12 @@ collectgarbage('collect')
fiber.sleep(0)
box.session.on_disconnect(on_disconnect) == on_disconnect
+
+c:close()
+box.schema.user.revoke('guest', 'execute', 'function', 'fast_call')
+box.schema.user.revoke('guest', 'execute', 'function', 'long_call')
+box.schema.user.revoke('guest', 'execute', 'function', 'wait_signal')
+box.schema.func.drop('fast_call')
+box.schema.func.drop('long_call')
+box.schema.func.drop('wait_signal')
+box.cfg{readahead = readahead}
--
2.17.1
next reply other threads:[~2020-07-03 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 14:23 Alexander V. Tikhonov [this message]
2020-07-03 15:44 Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e36a7ae2432664c03834f778e049b4bdb9782196.1593786047.git.avtikhon@tarantool.org \
--to=avtikhon@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] test: cleanup box/net.box_call_blocks_gh-946' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox