From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: modify TRIM() function signature
Date: Mon, 22 Apr 2019 13:43:26 +0300 [thread overview]
Message-ID: <e21e7eda-1e41-8a3d-3f6c-6f90410fa80c@tarantool.org> (raw)
In-Reply-To: <c52ef274-de0a-e6af-27fe-d063b4091223@tarantool.org>
>>>> + */
>>>> +static void
>>>> +trim_func_one_arg(sql_context * context, int argc, sql_value **argv)
>>>
>>> 13. In new code we use explicit 'struct' keyword for struct
>>> types - sql_context and sql_value. Also, we do not put whitepaces
>
> 5. Note, I said 'sql_value' too, and look at your code below. What
> have you missed?
Sorry, now I see that sql_value is a typedef and can not be prepended
with struct.
next prev parent reply other threads:[~2019-04-22 10:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 17:33 [tarantool-patches] " Roman Khabibov
2019-04-14 18:01 ` [tarantool-patches] " Vladislav Shpilevoy
2019-04-16 0:14 ` Roman Khabibov
2019-04-16 17:14 ` Vladislav Shpilevoy
2019-04-18 17:11 ` Roman Khabibov
2019-04-19 12:49 ` Vladislav Shpilevoy
2019-04-20 0:48 ` Roman Khabibov
2019-04-21 19:36 ` Vladislav Shpilevoy
2019-04-22 10:43 ` Vladislav Shpilevoy [this message]
2019-04-22 16:45 ` Roman Khabibov
2019-04-22 18:22 ` Vladislav Shpilevoy
2019-04-23 1:04 ` Roman Khabibov
2019-04-23 8:59 ` Vladislav Shpilevoy
2019-04-23 10:21 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e21e7eda-1e41-8a3d-3f6c-6f90410fa80c@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: modify TRIM() function signature' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox