From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1 6/7] sql: remove implicit cast from OP_MustBeInt
Date: Wed, 28 Jul 2021 23:51:18 +0300 [thread overview]
Message-ID: <e2076ad9d5584ffe545362157506fb95348b7f39.1627504973.git.imeevma@gmail.com> (raw)
In-Reply-To: <cover.1627504972.git.imeevma@gmail.com>
This patch removes implicit casting from STRING to number in
OP_MustBeInt opcode.
Part of #4470
---
src/box/sql/vdbe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
index 81551acf3..89e77baee 100644
--- a/src/box/sql/vdbe.c
+++ b/src/box/sql/vdbe.c
@@ -1435,7 +1435,8 @@ case OP_AddImm: { /* in1 */
*/
case OP_MustBeInt: { /* jump, in1 */
pIn1 = &aMem[pOp->p1];
- if (mem_to_int_precise(pIn1) != 0) {
+ enum field_type type = FIELD_TYPE_INTEGER;
+ if (!mem_is_num(pIn1) || mem_cast_implicit_number(pIn1, type) != 0) {
if (pOp->p2 != 0)
goto jump_to_p2;
diag_set(ClientError, ER_SQL_TYPE_MISMATCH,
--
2.25.1
next prev parent reply other threads:[~2021-07-28 20:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 20:51 [Tarantool-patches] [PATCH v1 0/7] Rework implicit cast Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 1/7] sql: rework implicit cast fo assignment Mergen Imeev via Tarantool-patches
2021-07-30 21:55 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-04 22:21 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:27 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 2/7] sql: remove implicit cast from comparison opcodes Mergen Imeev via Tarantool-patches
2021-08-04 22:24 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:33 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 3/7] sql: rework OP_Seek* opcodes Mergen Imeev via Tarantool-patches
2021-08-04 22:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:40 ` Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 4/7] sql: remove unnecessary calls of OP_ApplyType Mergen Imeev via Tarantool-patches
2021-08-04 22:26 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:41 ` Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 5/7] sql: remove implicit cast from OP_MakeRecord Mergen Imeev via Tarantool-patches
2021-08-04 22:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:43 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 20:51 ` Mergen Imeev via Tarantool-patches [this message]
2021-08-05 23:47 ` [Tarantool-patches] [PATCH v1 6/7] sql: remove implicit cast from OP_MustBeInt Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 7/7] sql: remove unused MEM cast functions Mergen Imeev via Tarantool-patches
2021-08-04 22:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:45 ` Mergen Imeev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2076ad9d5584ffe545362157506fb95348b7f39.1627504973.git.imeevma@gmail.com \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 6/7] sql: remove implicit cast from OP_MustBeInt' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox