From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org>, Igor Munkin <imun@tarantool.org>, Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v3 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables Date: Mon, 5 Jun 2023 17:21:18 +0300 [thread overview] Message-ID: <e1efb6e4-c537-8710-f203-5147f888dfbc@tarantool.org> (raw) In-Reply-To: <848c82043f91fcaa4883c711cfa85bf1a1bc9959.1685613304.git.skaplun@tarantool.org> Sergey, thanks for patches and fixes! LGTM with a minor comment below. On 6/5/23 13:41, Sergey Kaplun wrote: > When we set `LUA_TEST_ENV_MORE` variable to be used in the additional > env command for run testing if `"` is used to wrap the `LD_LIBRARY_PATH` > value the content of this environment variable is literally > `"/abs/path1:/abs/path2:...:"`. So, the first entry is treated as the > relative path starting with `"`. In that case if we need the library to > be loaded via FFI for this particular test, that loading fails with the > error "cannot open shared object file", since the path to it is > incorrect. > > This patch removes `"` wrapping for the aforementioned variables. Nit: I would also add a couple of words about how it is related to a whole patchset. Not it is not obvious. As I got it right at least a test "test/tarantool-tests/lj-flush-on-trace.test.lua" fails because it uses "DYLD_LIBRARY_PATH". > --- > test/tarantool-tests/CMakeLists.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index a428d009..38d6ae49 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -102,6 +102,11 @@ endif() > # loaded modules on MacOS instead of shared libraries as it is > # done on Linux and BSD, another environment variable should be > # used to guide <ffi.load> while searching the extension. > +# XXX: Be noticed that we shouldn't use `"` here to wrap > +# the variable's content. If we do this, the variable value will > +# contain `"` at the beginning and the end, so this `"` at the > +# beginning will be treated as the directory for the first entry > +# (the last subdirectory added). > if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > # XXX: Apple tries their best to "protect their users from > # malware". As a result SIP (see the link[1] below) has been > @@ -122,9 +127,9 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > # > # [1]: https://support.apple.com/en-us/HT204899 > # [2]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html > - list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH="${LD_LIBRARY_PATH}") > + list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH=${LD_LIBRARY_PATH}) > else() > - list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH="${LD_LIBRARY_PATH}") > + list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH}) > endif() > > # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list
next prev parent reply other threads:[~2023-06-05 14:21 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-05 10:41 [Tarantool-patches] [PATCH v3 luajit 0/6] Reworking C tests Sergey Kaplun via Tarantool-patches 2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables Sergey Kaplun via Tarantool-patches 2023-06-05 14:21 ` Sergey Bronnikov via Tarantool-patches [this message] 2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 2/6] test: introduce module for C tests Sergey Kaplun via Tarantool-patches 2023-06-05 15:08 ` Sergey Bronnikov via Tarantool-patches 2023-06-07 15:51 ` Sergey Bronnikov via Tarantool-patches 2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 3/6] test: introduce utils.h helper " Sergey Kaplun via Tarantool-patches 2023-06-05 15:11 ` Sergey Bronnikov via Tarantool-patches 2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 4/6] test: rewrite misclib-getmetrics-capi test in C Sergey Kaplun via Tarantool-patches 2023-06-07 16:25 ` Sergey Bronnikov via Tarantool-patches 2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 5/6] test: rewrite misclib-sysprof-capi " Sergey Kaplun via Tarantool-patches 2023-06-07 16:18 ` Sergey Bronnikov via Tarantool-patches 2023-06-05 10:41 ` [Tarantool-patches] [PATCH v3 luajit 6/6] test: rewrite lj-49-bad-lightuserdata " Sergey Kaplun via Tarantool-patches 2023-06-07 16:14 ` Sergey Bronnikov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e1efb6e4-c537-8710-f203-5147f888dfbc@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox