From: Oleg Babin <olegrok@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org,
alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] core: handle fiber cancellation for fiber.cond
Date: Tue, 3 Nov 2020 13:27:12 +0300 [thread overview]
Message-ID: <e12589ea-0560-385a-bb54-03c1f98e24ac@tarantool.org> (raw)
In-Reply-To: <20201103102018.GC517@tarantool.org>
Hi! Thanks for your comment and diff.
On 03/11/2020 13:20, Sergey Ostanevich wrote:
> So, my resolution will be: it is wrong to set a diag in an arbitrary
> place, without clear understanting of the reason. This is the case for
> the cond_wait machinery, since it doesn't know_why_ the fiber is
> cancelled.
>
> I propose to cover the case with condition on empty diag and call it a
> day.
Sounds reasonable. It seems to be ok.
next prev parent reply other threads:[~2020-11-03 10:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 16:29 sergos
2020-11-01 10:13 ` Oleg Babin
2020-11-03 10:20 ` Sergey Ostanevich
2020-11-03 10:27 ` Oleg Babin [this message]
2020-11-04 10:00 ` Leonid Vasiliev
2020-11-16 22:12 ` Vladislav Shpilevoy
2020-11-18 22:05 ` Sergey Ostanevich
2020-11-22 16:01 ` Vladislav Shpilevoy
2020-11-23 21:47 ` Sergey Ostanevich
2020-11-24 7:31 ` Sergey Ostanevich
2020-11-04 10:00 ` Leonid Vasiliev
2020-11-05 20:42 ` Sergey Ostanevich
2020-11-10 21:16 ` Sergey Ostanevich
2020-11-12 20:15 ` Sergey Ostanevich
2020-11-13 8:26 ` Leonid Vasiliev
2020-11-30 22:49 ` Alexander Turenko
2020-11-16 22:12 ` Vladislav Shpilevoy
2020-11-25 21:32 ` Vladislav Shpilevoy
2020-11-29 21:41 ` Sergey Ostanevich
2020-11-30 21:46 ` Alexander Turenko
2020-11-30 21:01 ` Vladislav Shpilevoy
2020-12-02 10:58 ` Alexander V. Tikhonov
2020-12-02 22:18 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e12589ea-0560-385a-bb54-03c1f98e24ac@tarantool.org \
--to=olegrok@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] core: handle fiber cancellation for fiber.cond' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox