From: Aleksandr Lyapunov <alyapunov@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 02/15] Check data_offset overflow in struct tuple Date: Mon, 6 Jul 2020 16:39:50 +0300 [thread overview] Message-ID: <e124af3e-060f-c0c7-c354-895da9deda13@tarantool.org> (raw) In-Reply-To: <0ce23cdd-5a37-e1a3-3b3c-c949120c9e96@tarantool.org> Thank for the review. On 05.07.2020 20:03, Vladislav Shpilevoy wrote: > +i1 = s:create_index('pk') >> + | --- >> + | ... >> +i2 = s:create_index('mk', {parts={{'[2][*]', 'uint'}}}) > 1. Why do you need a multikey index? This test lacks a comment. Mutlikey index creates a variadic-length offset table in a tuple. That is a simplest way to overflow it. Sure, I'll add a comment. >> diff --git a/test/box/huge_field_map_long.test.lua b/test/box/huge_field_map_long.test.lua >> new file mode 100644 > 3. Why do you need a 'long' test? The first test seems to be good enough. It's just another way to overflow offset table. For example 1.10 does not have multikey indexes, so only long test will crash it. And perhaps we'll merge into 1.10. There's also a chance that we'll fix https://github.com/tarantool/tarantool/issues/5085 and multikey test will not work.
next prev parent reply other threads:[~2020-07-06 13:39 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-03 6:33 [Tarantool-patches] [PATCH 00/15] Transaction engine for memtx engine Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 01/15] Update license file (2020) Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 02/15] Check data_offset overflow in struct tuple Aleksandr Lyapunov 2020-07-05 17:03 ` Vladislav Shpilevoy 2020-07-06 13:39 ` Aleksandr Lyapunov [this message] 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 03/15] tx: introduce dirty tuples Aleksandr Lyapunov 2020-07-05 17:04 ` Vladislav Shpilevoy 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 04/15] vinyl: rename tx_manager -> vy_tx_manager Aleksandr Lyapunov 2020-07-05 17:04 ` Vladislav Shpilevoy 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 05/15] tx: save txn in txn_stmt Aleksandr Lyapunov 2020-07-05 17:04 ` Vladislav Shpilevoy 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 06/15] tx: add TX status Aleksandr Lyapunov 2020-07-05 17:04 ` Vladislav Shpilevoy 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 07/15] tx: save preserve old tuple flag in txn_stmt Aleksandr Lyapunov 2020-07-05 17:05 ` Vladislav Shpilevoy 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 08/15] tx: introduce tx manager Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 09/15] tx: introduce prepare sequence number Aleksandr Lyapunov 2020-07-05 17:05 ` Vladislav Shpilevoy 2020-07-06 13:50 ` Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 10/15] tx: introduce txn_stmt_destroy Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 11/15] tx: introduce conflict tracker Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 12/15] tx: introduce txm_story Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 13/15] tx: indexes Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 14/15] tx: introduce point conflict tracker Aleksandr Lyapunov 2020-07-03 6:33 ` [Tarantool-patches] [PATCH 15/15] tx: use new tx managet in memtx Aleksandr Lyapunov 2020-07-05 17:03 ` [Tarantool-patches] [PATCH 00/15] Transaction engine for memtx engine Vladislav Shpilevoy 2020-07-06 13:29 ` Aleksandr Lyapunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e124af3e-060f-c0c7-c354-895da9deda13@tarantool.org \ --to=alyapunov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 02/15] Check data_offset overflow in struct tuple' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox