[tarantool-patches] Re: [PATCH v1 1/1] box: option to start tarantool with no format checks.

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the patch! LGTM.

On 21/09/2018 20:49, imeevma@tarantool.org wrote:
> It is a common case that an instance is running on a version
> 1.6.*, then is upgraded to 1.9 with box.schema.upgrade(). But
> some of users has malformed space formats, and some of them got
> and ignored errors on box.schema.upgrade(). Such half-upgraded
> data can not be used to start a new version due to format
> violations, and can not be rolled back because some of new system
> spaces managed to be created. And we can not repair raw xlogs and
> snapshots because we have no such tools and they are zipped.
> 
> So it would be useful to have a special box.cfg option
> ignore_space_formats. It would allow to start an instance on
> the spaces with malformed formats, fix them, create a snapshot
> and then start with the formats turned on.
> 
> Closes #3605
> 
> @TarantoolBot document
> Title: box.cfg option 'ignore_space_formats'
> The option allows to turn off space formats validation before
> the instance is started. Useful to fix malformed formats after
> an upgrade from version < 1.7.5 to >= 1.7.5.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3605-ignore-space-formats-option
> Issue: https://github.com/tarantool/tarantool/issues/3605
> 
>   src/box/alter.cc                     | 14 ++++++-
>   src/box/box.h                        |  1 +
>   src/box/lua/load_cfg.lua             |  2 +
>   src/main.cc                          |  1 +
>   test/app-tap/init_script.result      | 77 ++++++++++++++++++------------------
>   test/box-tap/ignore_formats.test.lua | 28 +++++++++++++
>   test/box/admin.result                |  2 +
>   test/box/cfg.result                  |  4 ++
>   8 files changed, 90 insertions(+), 39 deletions(-)
>   create mode 100755 test/box-tap/ignore_formats.test.lua
>