Re: [Tarantool-patches] [PATCHv3 1/2] test: increase timeout in -e assert(false) test

[Leonid Vasiliev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi! Thank you from the patch.
Generally LGTM.
See some comments below:


On 14.01.2021 12:45, Artem Starshov wrote:
> Set timeout to 60 sec for waiting operations with process,
> like in default timeout for `cond_wait` in test-run.
> ---
>   test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
> index 656fe212b..d259f37fd 100755
> --- a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
> +++ b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
> @@ -60,10 +60,12 @@ local TARANTOOL_PATH = arg[-1]
>   local output_file = fio.abspath('out.txt')
>   local line = ('%s -e "assert(false)" > %s 2>&1 & echo $!'):
>           format(TARANTOOL_PATH, output_file)
> -local process_waiting_timeout = 30.0
> -local file_read_timeout = 30.0
> -local file_read_interval = 0.2
> -local file_open_timeout = 30.0
> +
> +-- Like a default timeout for `cond_wait` in test-run
> +local process_waiting_timeout = 60.0
> +local file_read_timeout = 60.0
> +local file_open_timeout = 60.0

> +local file_read_interval = 0.01

The change is not corresponded with the commit title (this is a decrease
the timeout) and commit message. Please update the commit message or
move this change to a separate commit (as for me, the first is
preferable).

>   
>   local res = tap.test('gh-4983-tnt-e-assert-false-hangs', function(test)
>       test:plan(2)
>