Tarantool development patches archive
 help / color / mirror / Atom feed
From: Leonid Vasiliev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Artem Starshov <artemreyt@tarantool.org>,
	Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCHv3 1/2] test: increase timeout in -e assert(false) test
Date: Fri, 15 Jan 2021 12:13:08 +0300	[thread overview]
Message-ID: <e02140a3-1bee-926b-b9cd-11c0ef0eb242@tarantool.org> (raw)
In-Reply-To: <1c3430b506a42d5fe938be265b622b811b919d6d.1610615519.git.artemreyt@tarantool.org>

Hi! Thank you from the patch.
Generally LGTM.
See some comments below:


On 14.01.2021 12:45, Artem Starshov wrote:
> Set timeout to 60 sec for waiting operations with process,
> like in default timeout for `cond_wait` in test-run.
> ---
>   test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
> index 656fe212b..d259f37fd 100755
> --- a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
> +++ b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
> @@ -60,10 +60,12 @@ local TARANTOOL_PATH = arg[-1]
>   local output_file = fio.abspath('out.txt')
>   local line = ('%s -e "assert(false)" > %s 2>&1 & echo $!'):
>           format(TARANTOOL_PATH, output_file)
> -local process_waiting_timeout = 30.0
> -local file_read_timeout = 30.0
> -local file_read_interval = 0.2
> -local file_open_timeout = 30.0
> +
> +-- Like a default timeout for `cond_wait` in test-run
> +local process_waiting_timeout = 60.0
> +local file_read_timeout = 60.0
> +local file_open_timeout = 60.0

> +local file_read_interval = 0.01

The change is not corresponded with the commit title (this is a decrease
the timeout) and commit message. Please update the commit message or
move this change to a separate commit (as for me, the first is
preferable).

>   
>   local res = tap.test('gh-4983-tnt-e-assert-false-hangs', function(test)
>       test:plan(2)
> 

  reply	other threads:[~2021-01-15  9:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  9:45 [Tarantool-patches] [PATCHv3 0/2] test: -e assert(false) test fixup Artem Starshov via Tarantool-patches
2021-01-14  9:45 ` [Tarantool-patches] [PATCHv3 1/2] test: increase timeout in -e assert(false) test Artem Starshov via Tarantool-patches
2021-01-15  9:13   ` Leonid Vasiliev via Tarantool-patches [this message]
2021-01-15  9:17   ` Leonid Vasiliev via Tarantool-patches
2021-01-14  9:45 ` [Tarantool-patches] [PATCHv3 2/2] test: move helper functions to separated module " Artem Starshov via Tarantool-patches
2021-01-15  9:37   ` Leonid Vasiliev via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e02140a3-1bee-926b-b9cd-11c0ef0eb242@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=artemreyt@tarantool.org \
    --cc=lvasiliev@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCHv3 1/2] test: increase timeout in -e assert(false) test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox