From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0EE417030F; Fri, 15 Jan 2021 12:13:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0EE417030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610702006; bh=gfzezVHw2qMo29Iiwz0GagaiMmR2sJuZYWI/BAEC6Ro=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TwRUA+Vtn82TUgv6C5AO5QqZL1xEfyuORCIb1WXPJRqaNW1ULsNRJJKBSz6QtOKeT wvNcMKCgA1hRXS2B1jX+o06t+RiEiKCh9zvcuSSQXajdAUMmqIgze16kT7VPDEi9fP aQIyRlnq6pLc4yD5U3ZpIPYljV+OV18nlOtp6kE0= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AC7D97030F for ; Fri, 15 Jan 2021 12:13:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AC7D97030F Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1l0LAZ-00029V-Cn; Fri, 15 Jan 2021 12:13:23 +0300 To: Artem Starshov , Alexander Turenko References: <1c3430b506a42d5fe938be265b622b811b919d6d.1610615519.git.artemreyt@tarantool.org> Message-ID: Date: Fri, 15 Jan 2021 12:13:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1c3430b506a42d5fe938be265b622b811b919d6d.1610615519.git.artemreyt@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD9B382B274FF537389656BC690FF7BBE200894C459B0CD1B9086D988016C7856FD439F4A32A86B3185BC4EB4D07275D0E471E6F0AD5863D70 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F8E53417176C7207EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459430292EC88638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC5C32F25192867AFCDDF1453A6F01690CE12ECA0E5C34BF11389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD2691661749BA6B97735F0DFBB38B116E9C77B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050F437C869540D2AB0F9F804269016115C9B3661434B16C20AC78D18283394535A975ECD9A6C639B01BC09775C1D3CA48CFAC2D04D201A9A352089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C9B187695B4E7C35343847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5FB614AA530EE88B1C4ED851386C051726DA0C57B7EE6BD89D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A1AF43396E40A36F214B8FE143A425D24F0F656B0E64524E5D94BEB5BEA2599EFA910DA80C2D78581D7E09C32AA3244CDC50292BC0E6861ECCB8A7AF3EE7FDFB4DBEAD0ED6C55A80927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojT/h6YDL0UQ4iT0eOrjr5tA== X-Mailru-Sender: 48EFD2E18A91C559803250E574CC3D29B0979C8BF5DC6841A02619E45460A3BF5F9045B74F665CC8D35D514C7DAC97282D063C67CFD4E84987597EC79699C0E6F21BD4036121A32F7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCHv3 1/2] test: increase timeout in -e assert(false) test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Leonid Vasiliev via Tarantool-patches Reply-To: Leonid Vasiliev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you from the patch. Generally LGTM. See some comments below: On 14.01.2021 12:45, Artem Starshov wrote: > Set timeout to 60 sec for waiting operations with process, > like in default timeout for `cond_wait` in test-run. > --- > test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua > index 656fe212b..d259f37fd 100755 > --- a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua > +++ b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua > @@ -60,10 +60,12 @@ local TARANTOOL_PATH = arg[-1] > local output_file = fio.abspath('out.txt') > local line = ('%s -e "assert(false)" > %s 2>&1 & echo $!'): > format(TARANTOOL_PATH, output_file) > -local process_waiting_timeout = 30.0 > -local file_read_timeout = 30.0 > -local file_read_interval = 0.2 > -local file_open_timeout = 30.0 > + > +-- Like a default timeout for `cond_wait` in test-run > +local process_waiting_timeout = 60.0 > +local file_read_timeout = 60.0 > +local file_open_timeout = 60.0 > +local file_read_interval = 0.01 The change is not corresponded with the commit title (this is a decrease the timeout) and commit message. Please update the commit message or move this change to a separate commit (as for me, the first is preferable). > > local res = tap.test('gh-4983-tnt-e-assert-false-hangs', function(test) > test:plan(2) >