From: sergeyb@tarantool.org To: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, imun@tarantool.org Cc: alexander.turenko@tarantool.org Subject: [Tarantool-patches] [PATCH 11/19] Fix luacheck warnings in test/sql Date: Thu, 16 Jul 2020 17:11:40 +0300 [thread overview] Message-ID: <e00dccb81cffe9811a25c3897d5c27c1b1a203a5.1594907318.git.sergeyb@tarantool.org> (raw) In-Reply-To: <cover.1594907318.git.sergeyb@tarantool.org> From: Sergey Bronnikov <sergeyb@tarantool.org> Part of #4681 Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Reviewed-by: Igor Munkin <imun@tarantool.org> --- .luacheckrc | 36 +++++++++++++++++++++++++++++++++- test/sql/lua/sql_tokenizer.lua | 2 +- 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/.luacheckrc b/.luacheckrc index 789958fc8..646c844d6 100644 --- a/.luacheckrc +++ b/.luacheckrc @@ -45,7 +45,7 @@ exclude_files = { "test/engine_long/*.test.lua", "test/replication/*.test.lua", "test/sql-tap/**/*.lua", - "test/sql/**/*.lua", + "test/sql/*.test.lua", "test/swim/**/*.lua", "test/var/**/*.lua", "test/vinyl/**/*.lua", @@ -202,3 +202,37 @@ files["test/replication/lua/fast_replica.lua"] = { "wait_all", }, } +files["test/sql-tap/*.lua"] = { + ignore = { + -- Setting an undefined global variable. + -- https://github.com/tarantool/tarantool/issues/5173 + "111", + -- Accessing an undefined global variable. + -- https://github.com/tarantool/tarantool/issues/5174 + "113", + -- Unused local variable. + -- https://github.com/tarantool/tarantool/issues/5175 + "211", + -- A line consists of nothing but whitespace. + -- https://github.com/tarantool/tarantool/issues/5176 + "611", + -- A line contains trailing whitespace. + -- https://github.com/tarantool/tarantool/issues/5177 + "612", + -- Trailing whitespace in a string. + -- https://github.com/tarantool/tarantool/issues/5178 + "613", + -- Trailing whitespace in a comment. + -- https://github.com/tarantool/tarantool/issues/5179 + "614", + -- Inconsistent indentation (SPACE followed by TAB). + -- https://github.com/tarantool/tarantool/issues/5180 + "621", + -- Line is too long. + -- https://github.com/tarantool/tarantool/issues/5181 + "631" + } +} +files["test/sql-tap/lua/sqltester.lua"] = { + globals = {"table_match_regex_p"} +} diff --git a/test/sql/lua/sql_tokenizer.lua b/test/sql/lua/sql_tokenizer.lua index 9922d792d..ffe4fb4e8 100644 --- a/test/sql/lua/sql_tokenizer.lua +++ b/test/sql/lua/sql_tokenizer.lua @@ -134,7 +134,7 @@ end -- @retval Token type. If the rest of the SQL request consists of -- spaces and comments, then return TK_EMPTY. local function get_next_token(context) - local c = '' + local c repeat local i = context.offset c = context.sql:sub(i, i) -- 2.26.2
next prev parent reply other threads:[~2020-07-16 14:13 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-16 14:11 [Tarantool-patches] [PATCH 00/19] Add static analysis of Lua code in test/ with luacheck sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 01/19] Fix luacheck warnings in test/app-tap sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 02/19] Fix luacheck warnings in test/app sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 03/19] Fix luacheck warnings in test/box sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 04/19] Fix luacheck warnings in test/box-py sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 05/19] Fix luacheck warnings in test/box-tap sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 06/19] Fix luacheck warnings in test/engine sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 07/19] Fix luacheck warnings in test/engine_long sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 08/19] Fix luacheck warnings in test/long_run-py sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 09/19] Fix luacheck warnings in test/replication sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 10/19] Fix luacheck warnings in test/replication-py sergeyb 2020-07-16 14:11 ` sergeyb [this message] 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 12/19] Fix luacheck warnings in test/sql-tap sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 13/19] Fix luacheck warnings in test/swim sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 14/19] Fix luacheck warnings in test/vinyl sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 15/19] Fix luacheck warnings in test/wal_off sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 16/19] Fix luacheck warnings in test/xlog sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 17/19] Fix luacheck warnings in test/xlog-py sergeyb 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 18/19] Add luacheck supression for luajit test sergeyb 2020-07-20 19:46 ` Igor Munkin 2020-07-21 11:52 ` Sergey Bronnikov 2020-07-21 12:38 ` Igor Munkin 2020-07-16 14:11 ` [Tarantool-patches] [PATCH 19/19] luajit: bump new version sergeyb 2020-07-16 14:18 ` [Tarantool-patches] [PATCH] test: fix warnings spotted by luacheck sergeyb 2020-07-20 18:26 ` Igor Munkin 2020-10-30 13:59 ` Kirill Yukhin 2020-07-17 8:09 ` [Tarantool-patches] [PATCH 00/19] Add static analysis of Lua code in test/ with luacheck Sergey Bronnikov 2020-08-07 9:19 ` Igor Munkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e00dccb81cffe9811a25c3897d5c27c1b1a203a5.1594907318.git.sergeyb@tarantool.org \ --to=sergeyb@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=imun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 11/19] Fix luacheck warnings in test/sql' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox