From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] schema: remove assert on wrong insert into _priv
Date: Tue, 28 Sep 2021 00:33:02 +0200 [thread overview]
Message-ID: <de656d56-47c9-8d87-0e99-8a2692030dde@tarantool.org> (raw)
In-Reply-To: <6849d9f6-c34b-db33-ee64-a20f9201b01d@tarantool.org>
Hi! Thanks for the fixes!
On 27.09.2021 08:41, Mergen Imeev wrote:
> Hi!
>
> On 09.09.2021 14:07, Mergen Imeev wrote:
>> Hi! Thank you for the review! My answers, diff and new patch below.
>>
>> On Tue, Sep 07, 2021 at 11:59:58PM +0200, Vladislav Shpilevoy wrote:
>>> Hi! Thanks for the patch!
>>>
>>> See 4 comments below.
>>>
>>> On 06.09.2021 10:11, imeevma@tarantool.org wrote:
>>>> Prior to this patch, an assertion was throwed if a tuple with an
>>> 1. throwed -> thrown.
>>>
>> Fixed.
I still see it on the branch.
>>>> incorrect id was inserted into the _priv system space. This bug
>>>> appeared only in the debug build.
>>>>
>>>> Closes #6295
>>>> ---
>>>> https://github.com/tarantool/tarantool/issues/6295
>>>> https://github.com/tarantool/tarantool/tree/imeevma/gh-6295-assert-on-insert-with-wrong-id
>>> 2. Could you please add a changelog?
>>>
>> Added.
Not on the branch.
Are you sure you pushed the new version?
next prev parent reply other threads:[~2021-09-27 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 8:11 Mergen Imeev via Tarantool-patches
2021-09-07 21:59 ` Vladislav Shpilevoy via Tarantool-patches
2021-09-09 11:07 ` Mergen Imeev via Tarantool-patches
2021-09-27 6:41 ` Mergen Imeev via Tarantool-patches
2021-09-27 22:33 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-09-29 6:32 ` Mergen Imeev via Tarantool-patches
2021-09-30 22:46 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-05 12:13 ` Kirill Yukhin via Tarantool-patches
-- strict thread matches above, loose matches on Subject: below --
2021-08-16 16:13 Mergen Imeev via Tarantool-patches
2021-08-17 12:32 ` Serge Petrenko via Tarantool-patches
2021-09-03 6:59 ` Mergen Imeev via Tarantool-patches
2021-09-06 8:05 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de656d56-47c9-8d87-0e99-8a2692030dde@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/1] schema: remove assert on wrong insert into _priv' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox