From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 570D66DB05; Tue, 28 Sep 2021 01:33:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 570D66DB05 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1632781985; bh=IuXmHnCR6BG/QefYdGZ1QFrQKyFnBfInrohg2fkkJts=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=qgHergQzZ5qHJuFnJLgCTCx/LJwA+QY9zGvft1x9fSJIGRVIHBYii1vpcsX8KFB6z 4BQupygdnfzuT/IBoKYW9WVw1GDISuZarrdss9AzPLrgCOshN1JS/28m+B7W2L4Nx8 mzAIaoiE7AHfiszDBVjrENJDd0Vd8Qhaf8O8WJvs= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 04C1B6DB05 for ; Tue, 28 Sep 2021 01:33:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 04C1B6DB05 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mUzBH-00087e-9M; Tue, 28 Sep 2021 01:33:03 +0300 To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org References: <38ac1b8d1ecae3352b8fe748def9e8a451239b9a.1630915850.git.imeevma@gmail.com> <4e091d79-84c5-9ba1-f624-185cfced6591@tarantool.org> <20210909110754.GA51222@tarantool.org> <6849d9f6-c34b-db33-ee64-a20f9201b01d@tarantool.org> Message-ID: Date: Tue, 28 Sep 2021 00:33:02 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <6849d9f6-c34b-db33-ee64-a20f9201b01d@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD96A58C36AA2E99649E150573C3DCDB299E3703FF91371DAED182A05F5380850403A24A76E4AEA67815C7D53BFA511033DEC98EC4309DD7434C5D54391E47077AC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789805A6418246A1AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CD8995A08F41566CEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F288816E229307C16D79880D08DCD1C6CACC7F00164DA146DAFE8445B8C89999728AA50765F79006375FFD5C25497261569FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3FB12F4B11BB5604F117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5246395718AED37E3E6E9C6E97C0A18FFEC2193E536234785D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75BFC02AB3DF06BA5A410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BC3EEE75EF3BACCFC432CEB41F127A382AEB46EAE565C87430E09467512D30D216D64A2E1D1392CA1D7E09C32AA3244CCCCD4708955B84A542A8BFE61736DB85853296C06374E602729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnnOrOlyI/jPEt0mzO305DQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D7D5D45402E49A25C402A1C13C9D5A17A3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] schema: remove assert on wrong insert into _priv X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the fixes! On 27.09.2021 08:41, Mergen Imeev wrote: > Hi! > > On 09.09.2021 14:07, Mergen Imeev wrote: >> Hi! Thank you for the review! My answers, diff and new patch below. >> >> On Tue, Sep 07, 2021 at 11:59:58PM +0200, Vladislav Shpilevoy wrote: >>> Hi! Thanks for the patch! >>> >>> See 4 comments below. >>> >>> On 06.09.2021 10:11, imeevma@tarantool.org wrote: >>>> Prior to this patch, an assertion was throwed if a tuple with an >>> 1. throwed -> thrown. >>> >> Fixed. I still see it on the branch. >>>> incorrect id was inserted into the _priv system space. This bug >>>> appeared only in the debug build. >>>> >>>> Closes #6295 >>>> --- >>>> https://github.com/tarantool/tarantool/issues/6295 >>>> https://github.com/tarantool/tarantool/tree/imeevma/gh-6295-assert-on-insert-with-wrong-id >>> 2. Could you please add a changelog? >>> >> Added. Not on the branch. Are you sure you pushed the new version?