Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32

[Oleg Babin <olegrok@tarantool.org>]

Hi! Your tests fail on Tarantool 1.10:

[001] Test failed! Result content mismatch:
[001] --- unit/router.result	Mon Mar  2 10:54:48 2020
[001] +++ unit/router.reject	Mon Mar  2 11:02:21 2020
[001] @@ -75,7 +75,7 @@
[001]   |   - - string
[001]   |     - '1'
[001]   |     - 477
[001] - |   - - ctype<struct 106>
[001] + |   - - number
[001]   |     - 1
[001]   |     - 477
[001]   | ...


Without taking this into account - patch LGTM.


On 29/02/2020 20:09, Vladislav Shpilevoy wrote:
> The aforementioned module won't print a warning only once. It will
> print all the errors again once a code reload happens, because
> 'local errors_issued = {}' will be called again on reload, and
> will clear 'errors_issued' table. But perhaps it was done
> intentionally.
> 
> I made it the same way. Intentionally. In that case it will help
> user to replace all bucket_id() calls during reloads, and after each
> reload he will be able to validate whether the message is printed
> again anywhere.

I see nothing bad to print deprecation message after code reload again. 
It doesn't lead to flood into logs as it's a manual action.

---
Oleg Babin