Re: [Tarantool-patches] [PATCH 3/4] feedback_daemon: send feedback on server start

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

05.04.2021 16:18, Vladislav Shpilevoy пишет:
> Hi! Thanks for the patch!
>
> On 02.04.2021 16:58, Serge Petrenko wrote:
>> Send the first report as soon as instance's initial configuration
>> finishes.
>>
>> Closes #5750
>> ---
>> diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua
>> index d00eedf39..2ce768642 100644
>> --- a/src/box/lua/feedback_daemon.lua
>> +++ b/src/box/lua/feedback_daemon.lua
>> @@ -345,7 +345,7 @@ local function guard_loop(self)
>>       while true do
>>   
>>           if get_fiber_id(self.fiber) == 0 then
>> -            self.fiber = fiber.create(feedback_loop, self)
>> +            self.fiber = fiber.new(feedback_loop, self)
> Why?

With fiber.create() feedback daemon proceeds to sending the "initial 
report" even before
lua's box.cfg() exits. This shouldn't break anything, as far as I 
understand, but
`tarantoolctl.test.lua` failed on my machine without this change.



-- 
Serge Petrenko