From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Oleg Piskunov <o.piskunov@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1] test: fix flaky sql/func-recreate Date: Wed, 8 Apr 2020 10:11:43 +0300 [thread overview] Message-ID: <dd5536f61d0adc2b5752644e7a90f83bf9ef188b.1586329704.git.avtikhon@tarantool.org> (raw) Found that time limit in function used for testing in sql/func-recreate test not enough for some time. Fiber set next is too near the time limit. Decided to increase the time limit of the function, anyway it checks its value at the test. Close #4384 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4384-increase-waitfor-time Issue: https://github.com/tarantool/tarantool/issues/4384 test/sql/func-recreate.result | 6 +++--- test/sql/func-recreate.test.lua | 2 +- test/sql/suite.ini | 1 - 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/test/sql/func-recreate.result b/test/sql/func-recreate.result index 73fb03cc4..c28e2c071 100644 --- a/test/sql/func-recreate.result +++ b/test/sql/func-recreate.result @@ -18,7 +18,7 @@ box.internal.sql_create_function('WAITFOR', 'INT', function (n) fiber.sleep(n) r ch = fiber.channel(1) --- ... -_ = fiber.create(function () ch:put(box.execute('select WAITFOR(0.2)')) end) +_ = fiber.create(function () ch:put(box.execute('select WAITFOR(0.5)')) end) --- ... fiber.sleep(0.1) @@ -32,10 +32,10 @@ box.internal.sql_create_function('WAITFOR', 'INT', function (n) require('fiber') ch:get() --- - metadata: - - name: WAITFOR(0.2) + - name: WAITFOR(0.5) type: integer rows: - - [0.2] + - [0.5] ... box.internal.sql_create_function('WAITFOR', 'INT', function (n) require('fiber').sleep(n) return n end) --- diff --git a/test/sql/func-recreate.test.lua b/test/sql/func-recreate.test.lua index 753e9ca4d..fa480288f 100644 --- a/test/sql/func-recreate.test.lua +++ b/test/sql/func-recreate.test.lua @@ -8,7 +8,7 @@ box.internal.sql_create_function('WAITFOR', 'INT', function (n) fiber.sleep(n) r ch = fiber.channel(1) -_ = fiber.create(function () ch:put(box.execute('select WAITFOR(0.2)')) end) +_ = fiber.create(function () ch:put(box.execute('select WAITFOR(0.5)')) end) fiber.sleep(0.1) box.internal.sql_create_function('WAITFOR', 'INT', function (n) require('fiber').sleep(n) return n end) diff --git a/test/sql/suite.ini b/test/sql/suite.ini index a8664c510..cc1d641a8 100644 --- a/test/sql/suite.ini +++ b/test/sql/suite.ini @@ -11,4 +11,3 @@ release_disabled = errinj.test.lua view_delayed_wal.test.lua sql-debug.test.lua disabled = sql-statN-index-drop.test.lua pretest_clean = True fragile = dll.test.lua ; gh-4427 - func-recreate.test.lua ; gh-4384 -- 2.17.1
next reply other threads:[~2020-04-08 7:11 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-08 7:11 Alexander V. Tikhonov [this message] 2020-04-10 14:18 ` Sergey Bronnikov 2020-04-13 9:29 ` Oleg Piskunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dd5536f61d0adc2b5752644e7a90f83bf9ef188b.1586329704.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=o.piskunov@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] test: fix flaky sql/func-recreate' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox