From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v9 4/7] lua: remove exceptions from function luaL_tofield()
Date: Fri, 29 Mar 2019 22:26:17 +0300 [thread overview]
Message-ID: <dd43162c-ae74-d7f7-8679-4a3a2022c349@tarantool.org> (raw)
In-Reply-To: <20190322155309.GF6548@chai>
On 22/03/2019 18:53, Konstantin Osipov wrote:
> * imeevma@tarantool.org <imeevma@tarantool.org> [19/03/22 13:57]:
>> case LUA_TCDATA:
>> {
>> - uint32_t ctypeid = 0;
>> - void *cdata = luaL_checkcdata(L, index, &ctypeid);
>> + GCcdata *cd = cdataV(L->base + index - 1);
>> + void *cdata = (void *)cdataptr(cd);
>> +
>
> What is the reason for this change?
Because luaL_checkcdata throws. So here it is partially inlined.
>
>
> --
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
>
next prev parent reply other threads:[~2019-03-29 19:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 10:50 [tarantool-patches] [PATCH v9 0/7] sql: remove box.sql.execute imeevma
2019-03-22 10:50 ` [tarantool-patches] [PATCH v9 1/7] sql: add column name to SQL change counter imeevma
2019-03-22 15:42 ` [tarantool-patches] " Konstantin Osipov
2019-03-25 19:34 ` Mergen Imeev
2019-03-29 12:00 ` Kirill Yukhin
2019-03-22 10:50 ` [tarantool-patches] [PATCH v9 2/7] sql: fix error code for SQL errors in execute.c imeevma
2019-03-22 15:45 ` [tarantool-patches] " Konstantin Osipov
2019-03-26 21:48 ` Vladislav Shpilevoy
2019-03-27 11:43 ` Konstantin Osipov
2019-03-28 17:46 ` Mergen Imeev
2019-03-29 12:01 ` Kirill Yukhin
2019-03-22 10:50 ` [tarantool-patches] [PATCH v9 3/7] sql: remove box.sql.debug() imeevma
2019-03-22 15:46 ` [tarantool-patches] " Konstantin Osipov
2019-03-25 19:39 ` Mergen Imeev
2019-03-26 21:48 ` Vladislav Shpilevoy
2019-03-28 17:48 ` Mergen Imeev
2019-03-28 18:01 ` Vladislav Shpilevoy
2019-03-29 12:02 ` Kirill Yukhin
2019-03-22 10:50 ` [tarantool-patches] [PATCH v9 4/7] lua: remove exceptions from function luaL_tofield() imeevma
2019-03-22 15:53 ` [tarantool-patches] " Konstantin Osipov
2019-03-29 19:26 ` Vladislav Shpilevoy [this message]
2019-03-26 21:48 ` Vladislav Shpilevoy
2019-03-28 17:54 ` Mergen Imeev
2019-03-28 18:40 ` Vladislav Shpilevoy
2019-03-28 19:56 ` Mergen Imeev
2019-03-28 21:41 ` Mergen Imeev
2019-03-29 21:06 ` Vladislav Shpilevoy
2019-03-22 10:50 ` [tarantool-patches] [PATCH v9 5/7] iproto: create port_sql imeevma
2019-03-22 15:55 ` [tarantool-patches] " Konstantin Osipov
2019-03-22 10:50 ` [tarantool-patches] [PATCH v9 6/7] sql: create box.execute() imeevma
2019-03-22 15:57 ` [tarantool-patches] " Konstantin Osipov
2019-03-22 10:50 ` [tarantool-patches] [PATCH v9 7/7] sql: remove box.sql.execute() imeevma
2019-03-26 21:48 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-28 20:13 ` Mergen Imeev
2019-03-29 21:06 ` Vladislav Shpilevoy
2019-03-29 21:07 ` [tarantool-patches] Re: [PATCH v9 0/7] sql: remove box.sql.execute Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd43162c-ae74-d7f7-8679-4a3a2022c349@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v9 4/7] lua: remove exceptions from function luaL_tofield()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox