Re: [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test

[Artem via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, thanks for review!

21.01.2021 19:20, Sergey Bronnikov пишет:
> Thanks for the patch!
>
> I think it would be more clear if you will add reasons
>
> why we need to reduce timeout for two times.
Done.
>
> On 18.01.2021 15:45, Artem Starshov wrote:
>> Set timeout to 60 sec for waiting operations with process,
>> like in default timeout for `cond_wait` in test-run.
>>
>> Follows up #4983
>> ---
>>   test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua 
>> b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
>> index 656fe212b..c8313770e 100755
>> --- a/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
>> +++ b/test/app-tap/gh-4983-tnt-e-assert-false-hangs.test.lua
>> @@ -60,10 +60,12 @@ local TARANTOOL_PATH = arg[-1]
>>   local output_file = fio.abspath('out.txt')
>>   local line = ('%s -e "assert(false)" > %s 2>&1 & echo $!'):
>>           format(TARANTOOL_PATH, output_file)
>> -local process_waiting_timeout = 30.0
>> -local file_read_timeout = 30.0
>> +
>> +-- Like a default timeout for `cond_wait` in test-run
>> +local process_waiting_timeout = 60.0
>> +local file_read_timeout = 60.0
>> +local file_open_timeout = 60.0
>>   local file_read_interval = 0.2
>> -local file_open_timeout = 30.0
>>     local res = tap.test('gh-4983-tnt-e-assert-false-hangs', 
>> function(test)
>>       test:plan(2)