From: Alex Khatskevich <avkhatskevich@tarantool.org>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2] sql: fix decode analyze sample
Date: Tue, 19 Jun 2018 17:59:38 +0300 [thread overview]
Message-ID: <dc669e36-b9e4-7ed8-89ae-68d3944e3fc8@tarantool.org> (raw)
In-Reply-To: <B3ED2159-1411-462D-A71F-A208BEED6148@tarantool.org>
> As far as I understand, there is only one call of sql_stat4_column().
> You may make this function static and move to where.c,
> if you want so.
Ok.
Let it be here by now.
> + /* Typecast byte array. */
> I guess, it is obsolete comment.
Deleted
>> + int col_cnt = mp_decode_array(&a);
> mp_decode_array returns uint32_t, so lets use this type.
Fixed
>> + if (mem == NULL) {
>> + diag_set(OutOfMemory, sizeof(Mem), "sqlite3ValueNew”,
> sizeof(struct Mem) or *mem
Fixed
> The rest seems OK to me.
next prev parent reply other threads:[~2018-06-19 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:50 [tarantool-patches] " AKhatskevich
2018-06-19 1:12 ` [tarantool-patches] " n.pettik
2018-06-19 8:18 ` Alex Khatskevich
2018-06-19 13:55 ` n.pettik
2018-06-19 14:59 ` Alex Khatskevich [this message]
2018-06-29 15:05 ` n.pettik
2018-06-29 15:09 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc669e36-b9e4-7ed8-89ae-68d3944e3fc8@tarantool.org \
--to=avkhatskevich@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2] sql: fix decode analyze sample' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox