From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] console: fix usage of an undeclared variable
Date: Thu, 17 Oct 2019 23:26:04 +0200 [thread overview]
Message-ID: <dc55a2a6-04f4-c436-1565-2294fd0b39f5@tarantool.org> (raw)
In-Reply-To: <20191017211946.GG9698@uranus.lan>
On 17/10/2019 23:19, Cyrill Gorcunov wrote:
> On Thu, Oct 17, 2019 at 11:22:56PM +0200, Vladislav Shpilevoy wrote:
>>> Yes, and it means we will get nil here, and the caller code
>>> threat it as no-error and return empty string upward.
>>
>> No, it was not nil. It was:
>>
>> localhost:3313>
>> ---
>> - error: 'builtin/box/console.lua:454: variable ''rc'' is not declared'
>> ...
>
> Aha! I happen to miss that. Thanks for the point!
>
It would be nil in case a user turned strict mode off.
next prev parent reply other threads:[~2019-10-17 21:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 19:50 [Tarantool-patches] " Vladislav Shpilevoy
2019-10-17 20:00 ` Cyrill Gorcunov
2019-10-17 20:31 ` [Tarantool-patches] [tarantool-patches] " Vladislav Shpilevoy
2019-10-17 21:05 ` Cyrill Gorcunov
2019-10-17 21:08 ` Cyrill Gorcunov
2019-10-17 21:18 ` Vladislav Shpilevoy
2019-10-17 21:15 ` Cyrill Gorcunov
2019-10-17 21:22 ` Vladislav Shpilevoy
2019-10-17 21:19 ` Cyrill Gorcunov
2019-10-17 21:26 ` Vladislav Shpilevoy [this message]
2019-10-17 21:31 ` Cyrill Gorcunov
2019-10-17 21:06 ` [Tarantool-patches] " Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc55a2a6-04f4-c436-1565-2294fd0b39f5@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] console: fix usage of an undeclared variable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox