Re: [Tarantool-patches] [PATCH 1/1] election: fix box.ctl.promote() crash on 0 LSN

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for the review!

>> diff --git a/test/replication/gh-5430-master3.lua b/test/replication/gh-5430-master3.lua
>> new file mode 100644
>> index 000000000..eff479a68
>> --- /dev/null
>> +++ b/test/replication/gh-5430-master3.lua
>> @@ -0,0 +1,12 @@
>> +#!/usr/bin/env tarantool
>> +
>> +require('console').listen(os.getenv('ADMIN'))
>> +
>> +box.cfg({
>> +    listen = 'unix/:./master3.sock',
>> +    replication = {
>> +        'unix/:./master1.sock',
>> +    },
>> +    replication_synchro_quorum = 3,
>> +    replication_timeout = 0.5,
>> +})
> 
> 
> I'd create a single lua file, gh-5430-master.lua, and 3 symlinks.
> 
> listening socket may be deduced from filename, and
> 
> replication_synchro_quorum might be passed as a parameter.

Too many differences. I need a grant in one master, ready_only in another
master, different quorum and replication in the third master. I don't like
how these monstrous files look in the end having all these symbolic links
at them. Here it is a bit of code duplication, but you can always easily
say which node how is configured.

> I don't insist, LGTM anyways.

Pushed to master, 2.8, 2.7.