From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B7E126EC55; Tue, 27 Jul 2021 00:54:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B7E126EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627336463; bh=mwbYjcOmMHKkfcTlWqOS1ILe8hyNYSaIMt57EWI/EdQ=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=K6mwPQSMFl6JDLonEeaRDh/TH0NNI7V7rQJbDGkOEzPXGOgag2s4Y1C2CaH6rjs5u NkGhdj0+uQubfHBnjv2CmTEefs5aOgkIBGKxCZz+o0L0K68ouxgBT9Y7CMm16dOOTU k75KTsxL3gnNzT6uAcKM8x3xWxmO/jPrpCsIJOuk= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8246C6EC55 for ; Tue, 27 Jul 2021 00:54:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8246C6EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m88YH-0000kV-QZ; Tue, 27 Jul 2021 00:54:22 +0300 To: Sergey Petrenko , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com References: <71a67913af750aa487571ee14aafde4e7981b0ee.1626996633.git.v.shpilevoy@tarantool.org> Message-ID: Date: Mon, 26 Jul 2021 23:54:20 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30288BCF456A452EC429C5145D5B58EFD182A05F53808504054C1972C93D969F1C3E99861290A25C3F2E9B34FDFBB24DBC62003C93A2CF00E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BBC4AF2A01A27A06EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F907CB39E8CA2E228638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F52EBEFA6AC0A46C385FF87D3BECB362117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209ECD01F8117BC8BEA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C565C1E6824D8037B43847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5057B7CCDB188F8ABE47FB9306FCC5788A6 X-C1DE0DAB: 0D63561A33F958A5CC7069D2C3934A61C7E909C6BE210E082BD1D7847C9E139CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FA7FF33AA1A4D21C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3463DBE2ADA183F62F892C1EF5A6A64F7204AFE06ACA9AEC8BE24A06ACFEDE55BE1E045F90B293E6E51D7E09C32AA3244C861A32C3B004C06C32C288CB32DC464963871F383B54D9B3FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW5+gxr9wvj5xrw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D8EE7EEFA4723CC0AF86F3BAED6733EFE3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/1] election: fix box.ctl.promote() crash on 0 LSN X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the review! >> diff --git a/test/replication/gh-5430-master3.lua b/test/replication/gh-5430-master3.lua >> new file mode 100644 >> index 000000000..eff479a68 >> --- /dev/null >> +++ b/test/replication/gh-5430-master3.lua >> @@ -0,0 +1,12 @@ >> +#!/usr/bin/env tarantool >> + >> +require('console').listen(os.getenv('ADMIN')) >> + >> +box.cfg({ >> +    listen = 'unix/:./master3.sock', >> +    replication = { >> +        'unix/:./master1.sock', >> +    }, >> +    replication_synchro_quorum = 3, >> +    replication_timeout = 0.5, >> +}) > > > I'd create a single lua file, gh-5430-master.lua, and 3 symlinks. > > listening socket may be deduced from filename, and > > replication_synchro_quorum might be passed as a parameter. Too many differences. I need a grant in one master, ready_only in another master, different quorum and replication in the third master. I don't like how these monstrous files look in the end having all these symbolic links at them. Here it is a bit of code duplication, but you can always easily say which node how is configured. > I don't insist, LGTM anyways. Pushed to master, 2.8, 2.7.