Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
	Roman Khabibov <roman.habibov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] Add _vcollation and fetch in net.box
Date: Mon, 3 Jun 2019 20:45:03 +0200	[thread overview]
Message-ID: <dbad3b38-e045-ce35-de4e-5454e05da3a5@tarantool.org> (raw)
In-Reply-To: <cover.1559219194.git.roman.habibov@tarantool.org>

Please, provide name of the branch, and issue link.
There are 2 branches on this issue, and I don't know
which one to review.

On 30/05/2019 15:36, Roman Khabibov wrote:
> As I understood "readable for all" means that filter for
> "_vcollation" must always return "true", because the condition
> "User has read access to according system space" is always
> met.
> 
> Roman Khabibov (2):
>   schema: add "_vcollation" sysview
>   net.box: fetch '_vcollation' sysview into the module
> 
>  src/box/bootstrap.snap             | Bin 4374 -> 4441 bytes
>  src/box/lua/net_box.lua            |  24 ++++++--
>  src/box/lua/space.cc               |   2 +
>  src/box/lua/upgrade.lua            |  25 ++++++++
>  src/box/schema_def.h               |   2 +
>  src/box/sysview.c                  |  13 ++++
>  test/app-tap/tarantoolctl.test.lua |   4 +-
>  test/box-py/bootstrap.result       |  13 +++-
>  test/box/access_misc.result        |   4 ++
>  test/box/access_sysview.result     |  92 ++++++++++++++++++++++++++---
>  test/box/access_sysview.test.lua   |  30 ++++++++++
>  test/box/alter.result              |   6 +-
>  test/box/net.box.result            |   2 +-
>  test/box/stat_net.result           |   4 +-
>  test/wal_off/alter.result          |   2 +-
>  15 files changed, 201 insertions(+), 22 deletions(-)
> 

  parent reply	other threads:[~2019-06-03 18:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 12:36 [tarantool-patches] " Roman Khabibov
2019-05-30 12:36 ` [tarantool-patches] [PATCH 1/2] schema: add "_vcollation" sysview Roman Khabibov
2019-06-04 16:31   ` Vladimir Davydov
2019-06-05 17:08     ` [tarantool-patches] " Roman Khabibov
2019-06-05 17:56       ` Vladimir Davydov
2019-06-06 15:18         ` Roman Khabibov
2019-05-30 12:36 ` [tarantool-patches] [PATCH 2/2] net.box: fetch '_vcollation' sysview into the module Roman Khabibov
2019-06-04 16:36   ` Vladimir Davydov
2019-06-05 17:08     ` [tarantool-patches] " Roman Khabibov
2019-06-05 17:28       ` Vladimir Davydov
2019-06-06 15:22         ` Roman Khabibov
2019-06-06 16:00         ` Roman Khabibov
2019-06-06 17:00           ` Vladimir Davydov
2019-06-03 18:45 ` Vladislav Shpilevoy [this message]
2019-06-04 15:54 ` [tarantool-patches] [PATCH 0/2] Add _vcollation and fetch in net.box Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbad3b38-e045-ce35-de4e-5454e05da3a5@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=roman.habibov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 0/2] Add _vcollation and fetch in net.box' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox