From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1 1/4] build: fix Werror warning in src/box/txn.c Date: Wed, 14 Oct 2020 19:35:43 +0300 [thread overview] Message-ID: <db71f95c3f2d20dbebc8ef7a0013e403751f8b53.1602693164.git.avtikhon@tarantool.org> (raw) Found on GCC 4.8.5 on CentOS 7 issue: build/usr/src/debug/tarantool-2.6.0.144/src/box/txn.c:944:30: error: ‘limbo_entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (txn_limbo_wait_complete(&txn_limbo, limbo_entry) < 0) Set limbo_entry variable to NULL on initialization. Needed for #4941 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4941-gcc-old Issue: https://github.com/tarantool/tarantool/issues/4941 src/box/txn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/box/txn.c b/src/box/txn.c index 4f5484ec5..eb725aaa9 100644 --- a/src/box/txn.c +++ b/src/box/txn.c @@ -886,7 +886,7 @@ int txn_commit(struct txn *txn) { struct journal_entry *req; - struct txn_limbo_entry *limbo_entry; + struct txn_limbo_entry *limbo_entry = NULL; txn->fiber = fiber(); -- 2.25.1
next reply other threads:[~2020-10-14 16:35 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 16:35 Alexander V. Tikhonov [this message] 2020-10-14 16:35 ` [Tarantool-patches] [PATCH v1 2/4] build: fix Werror warning in test/unit:fiber*.c* Alexander V. Tikhonov 2020-10-14 16:35 ` [Tarantool-patches] [PATCH v1 3/4] build: add Werror flag to CentOS7 packages build Alexander V. Tikhonov 2020-10-14 16:35 ` [Tarantool-patches] [PATCH v1 4/4] gitlab-ci: test default gcc on CentOS 7 Alexander V. Tikhonov 2020-10-15 8:53 ` [Tarantool-patches] [PATCH v1 1/4] build: fix Werror warning in src/box/txn.c Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=db71f95c3f2d20dbebc8ef7a0013e403751f8b53.1602693164.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 1/4] build: fix Werror warning in src/box/txn.c' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox