Re: [Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback for fibers switch-over

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the fix attempt!

>> To make lib/core more self-sufficient we could make cord_on_yield
>> inlined in fiber.h under a macros like LIBCORE_USE_DEFAULT_ON_YIELD.
>> Which would be set by default to 1, but to 0 in the executable file.
> 
> Oh, this is a nice one. It might be a solution but...
> 
>>
>> Could help not to change the test binaries, and whatever else depends
>> on lib/core, but does not care about Lua.
> 
> ...unfortunately it's not. At first, we need to build both libraries
> with the new define set to 1 and to 0. Furthermore, this leads to link
> all tests against "coretest" instead of original "core". However, tests
> implicitly dependent on "core" are still linked against it, so the issue
> is not solved.
> 
>>
>> I do not insist, but I will do that myself if someday I will need to
>> write a new unit test (raft, for example).
> 
> I would be glad to fix the issue, so let's return to it a bit later.
> I hope there is a CMake recipe or hack for this case.

Ok, then up to you what to do with it. I can't think of a simpler
solution for now, and I am ok with the current one.