From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Nikita Pettik <korablev@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] sql: boolean introduction follow-ups
Date: Thu, 27 Jun 2019 21:02:40 +0200 [thread overview]
Message-ID: <dad3513a-862b-f61a-2ea6-e4ad72348622@tarantool.org> (raw)
In-Reply-To: <cover.1561459671.git.korablev@tarantool.org>
Hi! Thanks for the patchset!
LGTM.
On 25/06/2019 13:42, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/boolean-follow-ups
>
> First patch gets rid of redundant conversion of results from booleans
> to numeric values 0 and 1 in testing framework (sqltester).
>
> Second one fixes obvious bug during comparison of booleans with values
> of other types.
>
> Nikita Pettik (2):
> sqltester: don't convert booleans to 0/1 numerics
> sql: fix antisymmetric boolean comparison in VDBE
>
> src/box/sql/vdbeaux.c | 2 +
> test/sql-tap/atof1.test.lua | 2 +-
> test/sql-tap/autoinc.test.lua | 2 +-
> test/sql-tap/cse.test.lua | 10 +-
> test/sql-tap/e_select1.test.lua | 8 +-
> test/sql-tap/func.test.lua | 42 +++---
> test/sql-tap/func5.test.lua | 30 ++++-
> .../gh-3251-string-pattern-comparison.test.lua | 18 +--
> test/sql-tap/in1.test.lua | 26 ++--
> test/sql-tap/in2.test.lua | 2 +-
> test/sql-tap/in3.test.lua | 16 +--
> test/sql-tap/in4.test.lua | 2 +-
> test/sql-tap/insert1.test.lua | 4 +-
> test/sql-tap/lua/sqltester.lua | 24 ----
> test/sql-tap/lua_sql.test.lua | 2 +-
> test/sql-tap/misc1.test.lua | 6 +-
> test/sql-tap/select1.test.lua | 2 +-
> test/sql-tap/select7.test.lua | 4 +-
> test/sql-tap/selectG.test.lua | 2 +-
> test/sql-tap/sql-errors.test.lua | 4 +-
> test/sql-tap/subquery.test.lua | 6 +-
> test/sql-tap/subselect.test.lua | 4 +-
> test/sql-tap/tkt-80e031a00f.test.lua | 148 ++++++++++-----------
> test/sql-tap/tkt-a7b7803e.test.lua | 16 +--
> test/sql-tap/tkt-b351d95f9.test.lua | 2 +-
> test/sql-tap/tkt1473.test.lua | 30 ++---
> test/sql-tap/tkt3346.test.lua | 2 +-
> test/sql-tap/tkt3493.test.lua | 28 ++--
> test/sql-tap/triggerC.test.lua | 2 +-
> test/sql-tap/types.test.lua | 2 +-
> test/sql-tap/where5.test.lua | 4 +-
> test/sql-tap/whereB.test.lua | 102 +++++++-------
> test/sql-tap/with2.test.lua | 6 +-
> 33 files changed, 283 insertions(+), 277 deletions(-)
>
next prev parent reply other threads:[~2019-06-27 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 11:42 [tarantool-patches] " Nikita Pettik
2019-06-25 11:42 ` [tarantool-patches] [PATCH 1/2] sqltester: don't convert booleans to 0/1 numerics Nikita Pettik
2019-06-25 11:42 ` [tarantool-patches] [PATCH 2/2] sql: fix antisymmetric boolean comparison in VDBE Nikita Pettik
2019-06-27 19:02 ` Vladislav Shpilevoy [this message]
2019-07-11 9:13 ` [tarantool-patches] Re: [PATCH 0/2] sql: boolean introduction follow-ups Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dad3513a-862b-f61a-2ea6-e4ad72348622@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] sql: boolean introduction follow-ups' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox