* [tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization
[not found] <8b8c10ef080d380f5b9e0ec45f5fcbdf73c209d8.1567433319.git.alexander.turenko@tarantool.org>
@ 2019-09-04 22:02 ` Vladislav Shpilevoy
2019-09-13 8:15 ` Kirill Yukhin
0 siblings, 1 reply; 2+ messages in thread
From: Vladislav Shpilevoy @ 2019-09-04 22:02 UTC (permalink / raw)
To: Alexander Turenko; +Cc: tarantool-patches, Kirill Yukhin
Hi! Thanks for the patch!
LGTM.
On 04/09/2019 00:42, Alexander Turenko wrote:
> This commit does not change a user visible behaviour. It refactors pwd
> module to explicitly divide code that fetches data from passwd / group
> databases from code that performs deserialization of the data to Lua
> tables.
>
> The idea of splitting of those actions appears when it was observed that
> a call of getpw() / getgr() leads to problems on some systems when it is
> invoked during passwd / group database traveral.
>
> Now it is more obvious that we don't call getpw() during passwd
> traversal and getgr() during group traveral.
>
> Follows up #4428 and #4447.
> ---
>
> This patch follows up the discussion in
> https://www.freelists.org/post/tarantool-patches/PATCH-lua-pwd-fix-passwd-and-group-traversal,1
>
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-4447-refactor-pwd
>
> src/lua/pwd.lua | 111 +++++++++++++++++++++++++++++++++---------------
> 1 file changed, 77 insertions(+), 34 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread* [tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization
2019-09-04 22:02 ` [tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization Vladislav Shpilevoy
@ 2019-09-13 8:15 ` Kirill Yukhin
0 siblings, 0 replies; 2+ messages in thread
From: Kirill Yukhin @ 2019-09-13 8:15 UTC (permalink / raw)
To: Vladislav Shpilevoy; +Cc: Alexander Turenko, tarantool-patches
Hello,
On 05 Sep 00:02, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> LGTM.
>
> On 04/09/2019 00:42, Alexander Turenko wrote:
> > This commit does not change a user visible behaviour. It refactors pwd
> > module to explicitly divide code that fetches data from passwd / group
> > databases from code that performs deserialization of the data to Lua
> > tables.
> >
> > The idea of splitting of those actions appears when it was observed that
> > a call of getpw() / getgr() leads to problems on some systems when it is
> > invoked during passwd / group database traveral.
> >
> > Now it is more obvious that we don't call getpw() during passwd
> > traversal and getgr() during group traveral.
> >
> > Follows up #4428 and #4447.
I've checked your patch into 1.10, 2.1, 2.2 and master.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-13 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <8b8c10ef080d380f5b9e0ec45f5fcbdf73c209d8.1567433319.git.alexander.turenko@tarantool.org>
2019-09-04 22:02 ` [tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization Vladislav Shpilevoy
2019-09-13 8:15 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox