[tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization

[tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization

[Vladislav Shpilevoy]

Hi! Thanks for the patch!

LGTM.

On 04/09/2019 00:42, Alexander Turenko wrote:
> This commit does not change a user visible behaviour. It refactors pwd
> module to explicitly divide code that fetches data from passwd / group
> databases from code that performs deserialization of the data to Lua
> tables.
> 
> The idea of splitting of those actions appears when it was observed that
> a call of getpw() / getgr() leads to problems on some systems when it is
> invoked during passwd / group database traveral.
> 
> Now it is more obvious that we don't call getpw() during passwd
> traversal and getgr() during group traveral.
> 
> Follows up #4428 and #4447.
> ---
> 
> This patch follows up the discussion in
> https://www.freelists.org/post/tarantool-patches/PATCH-lua-pwd-fix-passwd-and-group-traversal,1
> 
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-4447-refactor-pwd
> 
>  src/lua/pwd.lua | 111 +++++++++++++++++++++++++++++++++---------------
>  1 file changed, 77 insertions(+), 34 deletions(-)

[tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization

[Kirill Yukhin]

Hello,

On 05 Sep 00:02, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> LGTM.
> 
> On 04/09/2019 00:42, Alexander Turenko wrote:
> > This commit does not change a user visible behaviour. It refactors pwd
> > module to explicitly divide code that fetches data from passwd / group
> > databases from code that performs deserialization of the data to Lua
> > tables.
> > 
> > The idea of splitting of those actions appears when it was observed that
> > a call of getpw() / getgr() leads to problems on some systems when it is
> > invoked during passwd / group database traveral.
> > 
> > Now it is more obvious that we don't call getpw() during passwd
> > traversal and getgr() during group traveral.
> > 
> > Follows up #4428 and #4447.

I've checked your patch into 1.10, 2.1, 2.2 and master.

--
Regards, Kirill Yukhin