From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] alter: use good c++ style
Date: Mon, 13 Jul 2020 16:36:56 +0300 [thread overview]
Message-ID: <d9ad1b43-c2f8-74fe-c4d7-34a9e6f25c1c@tarantool.org> (raw)
In-Reply-To: <4107c5fb-11af-16df-26e2-2c134dc0a46b@tarantool.org>
Hi! Thanks for the review! all good except one more question below?
On 11.07.2020 22:53, Vladislav Shpilevoy wrote:
>
>> void
>> -UpdateSchemaVersion::alter(struct alter_space *alter)
>> +UpdateSchemaVersion::alter(struct alter_space *alter) noexcept
>> {
>> - (void)alter;
>> - ++schema_version;
>> + (void) alter;
>> + ++schema_version;
> 3. This change seems not to be related.
What are you suggesting to do with it? create separate commit? or don't
touch it? I hope I haven't to have an gh issue for that.
next prev parent reply other threads:[~2020-07-13 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 9:07 [Tarantool-patches] [PATCH 0/2] Simplify alter.cc Aleksandr Lyapunov
2020-07-08 9:07 ` [Tarantool-patches] [PATCH 1/2] alter: use good c++ style Aleksandr Lyapunov
2020-07-11 19:53 ` Vladislav Shpilevoy
2020-07-13 13:36 ` Aleksandr Lyapunov [this message]
2020-07-13 18:33 ` Vladislav Shpilevoy
2020-07-13 21:51 ` Timur Safin
2020-07-13 22:17 ` Vladislav Shpilevoy
2020-07-08 9:07 ` [Tarantool-patches] [PATCH 2/2] alter: use proper way to marry C and C++ Aleksandr Lyapunov
2020-07-08 10:41 ` Timur Safin
2020-07-11 19:53 ` Vladislav Shpilevoy
2020-07-08 9:13 ` [Tarantool-patches] [PATCH 0/2] Simplify alter.cc Aleksandr Lyapunov
2020-07-08 10:35 ` Timur Safin
-- strict thread matches above, loose matches on Subject: below --
2020-07-08 8:43 Aleksandr Lyapunov
2020-07-08 8:43 ` [Tarantool-patches] [PATCH 1/2] alter: use good c++ style Aleksandr Lyapunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ad1b43-c2f8-74fe-c4d7-34a9e6f25c1c@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] alter: use good c++ style' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox