From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 00/15] Transaction engine for memtx engine
Date: Mon, 6 Jul 2020 16:29:55 +0300 [thread overview]
Message-ID: <d9022c6b-d78d-1787-908f-f884ab0ddbe5@tarantool.org> (raw)
In-Reply-To: <ae7a2086-5b24-25c0-2493-78c549146cc9@tarantool.org>
Hi, thank for your reply.
Sure, I'll try to do it correctly when I send
next version, I hope today.
On 05.07.2020 20:03, Vladislav Shpilevoy wrote:
> Hi!
>
> Could you please provide branch and issue links, and put the
> reviewers in CC/TO? Like described here
> https://github.com/tarantool/tarantool/wiki/Code-review-procedure.
>
> I assume the branch is this:
> https://github.com/tarantool/tarantool/tree/alyapunov/gh-4897-memtx-tx-engine-v6
> And the issue is this:
> https://github.com/tarantool/tarantool/issues/4897
>
> The CI looks very broken:
> https://gitlab.com/tarantool/tarantool/-/pipelines/162943109
> I can't build the branch either.
>
> Besides, I see a dirty commit 'fixme' on the branch. What is it?
>
>> Work is still in progress but the patchset is ready for discussions.
> Would be nice to have some document with general overview of what is
> done. Usually this is an RFC. Or at least in the cover letter or in
> the commit messages and comments. This feature is definitely not an
> easy patch to understand from sources only in a short time.
prev parent reply other threads:[~2020-07-06 13:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 6:33 Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 01/15] Update license file (2020) Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 02/15] Check data_offset overflow in struct tuple Aleksandr Lyapunov
2020-07-05 17:03 ` Vladislav Shpilevoy
2020-07-06 13:39 ` Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 03/15] tx: introduce dirty tuples Aleksandr Lyapunov
2020-07-05 17:04 ` Vladislav Shpilevoy
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 04/15] vinyl: rename tx_manager -> vy_tx_manager Aleksandr Lyapunov
2020-07-05 17:04 ` Vladislav Shpilevoy
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 05/15] tx: save txn in txn_stmt Aleksandr Lyapunov
2020-07-05 17:04 ` Vladislav Shpilevoy
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 06/15] tx: add TX status Aleksandr Lyapunov
2020-07-05 17:04 ` Vladislav Shpilevoy
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 07/15] tx: save preserve old tuple flag in txn_stmt Aleksandr Lyapunov
2020-07-05 17:05 ` Vladislav Shpilevoy
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 08/15] tx: introduce tx manager Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 09/15] tx: introduce prepare sequence number Aleksandr Lyapunov
2020-07-05 17:05 ` Vladislav Shpilevoy
2020-07-06 13:50 ` Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 10/15] tx: introduce txn_stmt_destroy Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 11/15] tx: introduce conflict tracker Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 12/15] tx: introduce txm_story Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 13/15] tx: indexes Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 14/15] tx: introduce point conflict tracker Aleksandr Lyapunov
2020-07-03 6:33 ` [Tarantool-patches] [PATCH 15/15] tx: use new tx managet in memtx Aleksandr Lyapunov
2020-07-05 17:03 ` [Tarantool-patches] [PATCH 00/15] Transaction engine for memtx engine Vladislav Shpilevoy
2020-07-06 13:29 ` Aleksandr Lyapunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9022c6b-d78d-1787-908f-f884ab0ddbe5@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 00/15] Transaction engine for memtx engine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox