[tarantool-patches] Re: [PATCH v1 1/1] box: fix assert with multikey hybrid index

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

On 21/05/2019 19:59, Kirill Shcherbatov wrote:
> Thank you for your feedback! Done.
> ====================================================
> 
> Tarantool used to assume that offset_slot has an extension
> iff field_map_get_offset is called with multikey_idx >= 0.
> In fact, when some part of the index contains a multikey index
> placeholder, tuple_compare_* routines pass a tuple_hint in
> meaning of multikey index for each tuple_field_raw_by_part call,
> even for regular key_part that doesn't have array index
> placeholder (and, correspondingly, field_map extension).
> Thus this assumption is invalid.
> 
> This patch uses the fact that field_map slots that have extensoin

Typo "extensoin". 

> store negative offset to distinguish multikey and normal usage
> of the field_map_get_offset routine.
> 
> Closes #4234
> ---