Re: [Tarantool-patches] [PATCH 5/6] Add luacheck config

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch!

Consider more fixes below and on the branch in a separate commit.

====================

    Review fixes: luacheck

diff --git a/.luacheckrc b/.luacheckrc
index 83774d3f7..0862f7f2a 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -22,41 +22,36 @@ exclude_files = {
     ".git/**/*.lua",
 }
 
-files["**/*.lua"] = {ignore = {"212", "122"}}
-files["extra/dist/tarantoolctl.in"] = {ignore = {"431", "411", "122", "542", "212"}}
-files["src/lua/help.lua"] = {globals = {"help", "tutorial"}, ignore = {"113", "211"}}
+files["**/*.lua"] = {
+    globals = {"box", "_TARANTOOL", "help", "tutorial"},
+    ignore = {"212", "122"}
+}
+files["extra/dist/tarantoolctl.in"] = {ignore = {"431", "122", "542", "212"}}
 files["src/lua/swim.lua"] = {ignore = {"431"}}
 files["src/lua/fio.lua"] = {ignore = {"231"}}
 files["src/lua/init.lua"] = {ignore = {"121"}}
-files["src/lua/fiber.lua"] = {ignore = {"331", "311"}}
+files["src/lua/fiber.lua"] = {ignore = {"331"}}
 files["src/box/lua/serpent.lua"] = {globals = {"_ENV"}, ignore = {"431", "421", "631", "432", "542", "412", "422"}}
-files["src/box/lua/load_cfg.lua"] = {ignore = {"431", "143", "311", "542"}}
-files["src/box/lua/net_box.lua"] = {ignore = {"431", "211", "421", "432", "311", "231", "411", "412"}}
-files["src/box/lua/schema.lua"] = {globals = {"update_format", "iid", "role_check_grant_revoke_of_sys_priv"}, ignore = {"431", "211", "421", "213", "432", "311", "542", "412"}}
-files["src/box/lua/key_def.lua"] = {ignore = {"431"}}
-files["src/box/lua/feedback_daemon.lua"] = {ignore = {"211"}}
-files["src/box/lua/tuple.lua"] = {ignore = {"211", "421", "412"}}
-files["src/box/lua/upgrade.lua"] = {ignore = {"211", "421", "213"}}
-files["src/box/lua/console.lua"] = {globals = {"help"}, ignore = {"211", "143"}}
+files["src/box/lua/load_cfg.lua"] = {ignore = {"431", "143", "542"}}
+files["src/box/lua/net_box.lua"] = {ignore = {"431", "432", "231", "411",}}
+files["src/box/lua/schema.lua"] = {ignore = {"431", "213", "432", "542"}}
+files["src/box/lua/upgrade.lua"] = {ignore = {"213"}}
 files["test-run/test_run.lua"] = {ignore = {"412", "211", "431"}}
 files["test-run/lib/tarantool-python/test/cluster-py/master.lua"] = {ignore = {"121"}}
 files["test-run/lib/tarantool-python/unit/suites/box.lua"] = {ignore = {"121"}}
 files["test/**/*.lua"] = {ignore = {"631", "611", "614", "613", "612", "621", "112", "211", "432"}}
-files["test/app/*.lua"] = {ignore = {"111", "113"}}
 files["test/app/lua/fiber.lua"] = {ignore = {"111"}}
 files["test/app-tap/*.lua"] = {ignore = {"111", "113", "411", "431"}}
 files["test/app-tap/yaml.test.lua"] = {ignore = {"311"}}
 files["test/app-tap/module_api.test.lua"] = {ignore = {"311"}}
 files["test/app-tap/debug.test.lua"] = {ignore = {"421"}}
-files["test/app-tap/console_lua.test.lua"] = {ignore = {"412"}}
 files["test/app-tap/string.test.lua"] = {ignore = {"311"}}
 files["test/app-tap/logger.test.lua"] = {ignore = {"231"}}
 files["test/app-tap/snapshot.test.lua"] = {ignore = {"213"}}
 files["test/app-tap/msgpackffi.test.lua"] = {ignore = {"213"}}
 files["test/app-tap/http_client.test.lua"] = {ignore = {"213", "422", "412", "311"}}
-files["test/app-tap/fail_main.test.lua"] = {ignore = {"412"}}
-files["test/app-tap/tarantoolctl.test.lua"] = {ignore = {"511", "421"}}
-files["test/app-tap/lua/require_mod.lua"] = {ignore = {"113", "111"}}
+files["test/app-tap/tarantoolctl.test.lua"] = {ignore = {"421"}}
+files["test/app-tap/lua/require_mod.lua"] = {globals = {"exports"}}
 files["test/box/admin.test.lua"] = {ignore = {"213"}}
 files["test/box/lua/*.lua"] = {ignore = {"111"}}
 files["test/box/*.lua"] = {ignore = {"111", "113"}}