Re: [Tarantool-patches] [PATCH 2/4] uuid: expose additional from_string constructors

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch!

> diff --git a/src/lib/uuid/tt_uuid.c b/src/lib/uuid/tt_uuid.c
> index 1bd2e2cfe..94a0b15bb 100644
> --- a/src/lib/uuid/tt_uuid.c
> +++ b/src/lib/uuid/tt_uuid.c
> @@ -65,6 +65,15 @@ tt_uuid_create(struct tt_uuid *uu)
>  }
>  #endif
>  
> +extern inline int

'inline' modifier won't change anything. The function body is
not visible anyway.

> +tt_uuid_validate(struct tt_uuid *uu);
> +
> +extern inline int
> +tt_uuid_from_fmt_string(const char *in, struct tt_uuid *uu, const char *fmt);
> +
> +extern inline int
> +tt_uuid_from_lstring(const char *in, uint32_t len, struct tt_uuid *uu);
> +
>  extern inline int
>  tt_uuid_from_string(const char *in, struct tt_uuid *uu);
>  

There are unit tests for uuid in unit/uuid.c. You may need to
add tests for the new functions.