From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>,
Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] test: adjust the test name related to PAIRSMM flag
Date: Tue, 26 Nov 2019 22:03:23 +0100 [thread overview]
Message-ID: <d71f8997-832e-3dc3-8c84-1ec8bb217908@tarantool.org> (raw)
In-Reply-To: <20191126165407.ncmd7hepnpifgv6v@tkn_work_nb>
Hi!
On 26/11/2019 17:54, Alexander Turenko wrote:
> On Tue, Nov 26, 2019 at 06:47:38PM +0300, Igor Munkin wrote:
>> The prior name doesn't respect the naming convention used by test-run
>> thus this chunk was ignored by our testing machinery.
>>
>> Part-of tarantool/tarantool#4560
>>
>> Signed-off-by: Igor Munkin <imun@tarantool.org>
>> ---
>>
>> Branch: https://github.com/tarantool/luajit/tree/imun/test-name-fixup
>> Issue: https://github.com/tarantool/tarantool/issues/4560
>>
>>
>> test/{mmpairs_test.lua => mmpairs-tarantool-4560.test.lua} | 0
>> 1 file changed, 0 insertions(+), 0 deletions(-)
>> rename test/{mmpairs_test.lua => mmpairs-tarantool-4560.test.lua} (100%)
>>
>> diff --git a/test/mmpairs_test.lua b/test/mmpairs-tarantool-4560.test.lua
>> similarity index 100%
>> rename from test/mmpairs_test.lua
>> rename to test/mmpairs-tarantool-4560.test.lua
We have already agreed on, and use a different test name pattern:
gh-####-description.test.lua
Not
<description>-####.test.lua.
next prev parent reply other threads:[~2019-11-26 21:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:47 Igor Munkin
2019-11-26 16:54 ` Alexander Turenko
2019-11-26 20:58 ` Konstantin Osipov
2019-11-26 21:32 ` Igor Munkin
2019-11-27 8:32 ` Konstantin Osipov
2019-11-26 21:03 ` Vladislav Shpilevoy [this message]
2019-11-26 21:10 ` Igor Munkin
2019-11-27 15:50 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d71f8997-832e-3dc3-8c84-1ec8bb217908@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] test: adjust the test name related to PAIRSMM flag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox