Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun <skaplun@tarantool.org>
To: Igor Munkin <imun@tarantool.org>,
	Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH 1/2] test: force enable assert checks in release build
Date: Wed, 14 Oct 2020 20:03:58 +0300	[thread overview]
Message-ID: <d6caf3ced33ceb81113b91a65893fb6b935a0258.1602694006.git.skaplun@tarantool.org> (raw)
In-Reply-To: <cover.1602694006.git.skaplun@tarantool.org>

This patch fixes the regression introduced in scope of
5a61e1ab54b5c66bfebd836db1ac47996611e065 ('misc: add C and Lua API for
platform metrics'). As a result of the patch release build
was failed according to -Werror compiler flag and unused variables that
used only for assertions checks.

Force #undef NDEBUG directive leaves asserts on and allows not disable
newly added tests for release build.

Follows up tarantool/tarantool#5187
---
 test/misclib-getmetrics-capi/testgetmetrics.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/misclib-getmetrics-capi/testgetmetrics.c b/test/misclib-getmetrics-capi/testgetmetrics.c
index 8844b17..3b6f599 100644
--- a/test/misclib-getmetrics-capi/testgetmetrics.c
+++ b/test/misclib-getmetrics-capi/testgetmetrics.c
@@ -4,6 +4,7 @@
 
 #include <lmisclib.h>
 
+#undef NDEBUG
 #include <assert.h>
 
 static int base(lua_State *L)
-- 
2.28.0

  reply	other threads:[~2020-10-14 17:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 17:03 [Tarantool-patches] [PATCH 0/2] Fix broken CI after introduced LuaJIT metrics Sergey Kaplun
2020-10-14 17:03 ` Sergey Kaplun [this message]
2020-10-14 19:29   ` [Tarantool-patches] [PATCH 1/2] test: force enable assert checks in release build Igor Munkin
2020-10-14 19:33     ` Igor Munkin
2020-10-15  7:23     ` Sergey Kaplun
2020-10-15  9:02       ` Sergey Ostanevich
2020-10-14 17:03 ` [Tarantool-patches] [PATCH 2/2] test: disable jit related tests at FreeBSD Sergey Kaplun
2020-10-14 19:43   ` Igor Munkin
2020-10-15  7:25     ` Sergey Kaplun
2020-10-15  9:04       ` Sergey Ostanevich
2020-10-14 19:47 ` [Tarantool-patches] [PATCH 0/2] Fix broken CI after introduced LuaJIT metrics Igor Munkin
2020-10-15  9:22 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6caf3ced33ceb81113b91a65893fb6b935a0258.1602694006.git.skaplun@tarantool.org \
    --to=skaplun@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=sergos@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/2] test: force enable assert checks in release build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox