From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] fio: close unused descriptors automatically
Date: Mon, 10 Feb 2020 20:36:57 +0100 [thread overview]
Message-ID: <d5af6b5e-37d5-0340-ddfd-04746a3b9d47@tarantool.org> (raw)
In-Reply-To: <20200210063144.lcsc5vbe5jus7jt4@tarantool.org>
Hi!
On 10/02/2020 07:31, Kirill Yukhin wrote:
> Hello,
>
> On 09 фев 18:37, Vladislav Shpilevoy wrote:
>> test/app/fio.result | 93 +++++++++++++++++++++++++++++++++++++++++++
>> test/app/fio.test.lua | 58 +++++++++++++++++++++++++++
>
> Could you please put the test into separate file?
It contradicts with SOP.
"
We do not create a separate file for each feature - that
would lead to a huge number of files. For a bug fix,
please create a separate file with autonomous test case in
a correponding test suite. Name should follow this format:
<suite name>/gh-XXX-two-three-word-title
"
This is not a bugfix. It is a feature. Auto GC of FIO was never
documented anywhere, so this was not a bug. And according to SOP
it should not be in a separate file. But ok, I moved it.
> --
> Regards, Kirill Yukhin
>
next prev parent reply other threads:[~2020-02-10 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 17:37 Vladislav Shpilevoy
2020-02-09 17:38 ` Vladislav Shpilevoy
2020-02-09 18:34 ` Georgy Kirichenko
2020-02-10 19:36 ` Vladislav Shpilevoy
2020-03-02 20:51 ` Vladislav Shpilevoy
2020-02-09 19:25 ` Konstantin Osipov
2020-02-10 6:31 ` Kirill Yukhin
2020-02-10 8:20 ` Cyrill Gorcunov
2020-02-10 8:21 ` Cyrill Gorcunov
2020-02-10 19:36 ` Vladislav Shpilevoy [this message]
2020-02-14 11:48 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5af6b5e-37d5-0340-ddfd-04746a3b9d47@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] fio: close unused descriptors automatically' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox