Tarantool development patches archive
 help / color / mirror / Atom feed
From: Oleg Babin <olegrok@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
	tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 7/7] test: extend console lua test
Date: Mon, 18 May 2020 15:22:13 +0300	[thread overview]
Message-ID: <d5990c80-70dc-b8f9-b158-3da0811fabaf@tarantool.org> (raw)
In-Reply-To: <20200512135052.221379-8-gorcunov@gmail.com>

Hi. Thanks for your patch! LGTM.

On 12/05/2020 16:50, Cyrill Gorcunov wrote:
> To make sure ULL constants are not broken.
> 
> Part-of #4682
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   test/app-tap/console_lua.test.lua | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/test/app-tap/console_lua.test.lua b/test/app-tap/console_lua.test.lua
> index 8bb6eb0b3..dbfc3da11 100755
> --- a/test/app-tap/console_lua.test.lua
> +++ b/test/app-tap/console_lua.test.lua
> @@ -116,11 +116,26 @@ local cases = {
>           opts        = {block = false},
>           input       = '1, nil, box.NULL, nil',
>           expected    = '1, nil, box.NULL, nil',
> +    }, {
> +        name        = 'leading nils, box.NULL, line mode',
> +        opts        = {block = false},
> +        input       = 'nil, 1, nil, box.NULL, nil',
> +        expected    = 'nil, 1, nil, box.NULL, nil',
>       }, {
>           name        = 'trailing nils, box.NULL, block mode',
>           opts        = {block = true},
>           input       = '1, nil, box.NULL, nil',
>           expected    = '1, nil, box.NULL, nil',
> +    }, {
> +        name        = 'ULL constants, multireturn',
> +        opts        = {block = false},
> +        input       = '-1ULL, -2ULL, 1ULL, 2ULL',
> +        expected    = '18446744073709551615, 18446744073709551614, 1, 2',
> +    }, {
> +        name        = 'ULL key',
> +        opts        = {block = false},
> +        input       = '{[-1ULL] = 1}',
> +        expected    = '{[18446744073709551615] = 1}',
>       }, {
>           name        = 'empty output',
>           input       = '\\set output',
> 

  reply	other threads:[~2020-05-18 12:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 13:50 [Tarantool-patches] [PATCH 0/7] box/console: add support for internal types Cyrill Gorcunov
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 1/7] box/console: console_session_vtab -- use designated initialization Cyrill Gorcunov
2020-05-18 12:03   ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 2/7] box/console: use tabs instead of spaces in consolelib Cyrill Gorcunov
2020-05-18 12:04   ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 3/7] box/console: rename format to format_yaml Cyrill Gorcunov
2020-05-18 12:04   ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 4/7] box/console: rename luaL_yaml_default to serializer_yaml Cyrill Gorcunov
2020-05-18 12:11   ` Oleg Babin
2020-05-18 21:17     ` Igor Munkin
2020-05-19  6:47       ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 5/7] box/console: implement lua serializer Cyrill Gorcunov
2020-05-18 12:18   ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 6/7] box/console: switch to new " Cyrill Gorcunov
2020-05-18 12:21   ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 7/7] test: extend console lua test Cyrill Gorcunov
2020-05-18 12:22   ` Oleg Babin [this message]
2020-05-18 12:25     ` Cyrill Gorcunov
2020-05-18 12:46 ` [Tarantool-patches] [PATCH 0/7] box/console: add support for internal types Kirill Yukhin
  -- strict thread matches above, loose matches on Subject: below --
2020-05-08 11:47 Cyrill Gorcunov
2020-05-08 11:47 ` [Tarantool-patches] [PATCH 7/7] test: extend console lua test Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5990c80-70dc-b8f9-b158-3da0811fabaf@tarantool.org \
    --to=olegrok@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 7/7] test: extend console lua test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox