[tarantool-patches] Re: [PATCH v1 1/1] sql: drop useless code from os_unix.c

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hello. Thanks for the patch! See 2 comments below.

On 28/06/2018 18:21, Kirill Shcherbatov wrote:
> Resolves #3284.
> ---
> https://github.com/tarantool/tarantool/tree/kshch/gh-3284-no-os-unix
> https://github.com/tarantool/tarantool/issues/3284
>   src/box/sql/os.c        |  168 --
>   src/box/sql/os_unix.c   | 6195 ++++++++++-------------------------------------
>   src/box/sql/sqliteInt.h |    1 -
>   3 files changed, 1342 insertions(+), 5022 deletions(-)
> 
> diff --git a/src/box/sql/os.c b/src/box/sql/os.c
> index 38d3585..5a04edb 100644
> --- a/src/box/sql/os.c
> +++ b/src/box/sql/os.c
> @@ -123,123 +123,12 @@ sqlite3OsWrite(sqlite3_file * id, const void *pBuf, int amt, i64 offset)
>   	return id->pMethods->xWrite(id, pBuf, amt, offset);
>   }
>   
> -int
> -sqlite3OsTruncate(sqlite3_file * id, i64 size)
> -{
> -	return id->pMethods->xTruncate(id, size);
> -}

1. These functions still are visible in grep results.

2. And much more functions and constants are either unused, or just
declared, but has no implementation. Please, complete the patch. I have
pushed some of removals on the branch as a separate commit. Please,
squash and finalize.

> -
> -int
> -sqlite3OsSync(sqlite3_file * id, int flags)
> -{
> -	DO_OS_MALLOC_TEST(id);
> -	return id->pMethods->xSync(id, flags);
> -}
> -