Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
	tarantool-patches@dev.tarantool.org, skaplun@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2] Throw any errors before stack changes in trace stitching.
Date: Mon, 4 Mar 2024 16:32:54 +0300	[thread overview]
Message-ID: <d4a261cf-0ab8-4789-b1f9-1afe99e64e44@tarantool.org> (raw)
In-Reply-To: <20240301132127.136533-1-m.kokryashkin@tarantool.org>

Hi, Max

thanks for the patch! LGTM with a minor comment

On 3/1/24 16:21, Maxim Kokryashkin wrote:
> From: Mike Pall <mike>
>
> Thanks to doujiang24.
>
> (cherry-picked from commit 3f9389edc6cdf3f78a6896d550c236860aed62b2)
>
> The Lua stack is changed in the `recff_stitch`, so if the trace
> is aborted, for example, when the `maxsnap` is reached, and an
> error is thrown from there, the execution continues with an
> unbalanced stack.
>
> This patch adds a check for snapshot overflow to the
> `recff_stitch` to overcome the issue for the `LJ_TRERR_SNAPOV`
> case, but other cases remain unresolved and should be fixed in
> other series. For a detailed description of the remaining cases,
> see the issue[1].
>
> [1]: https://github.com/LuaJIT/LuaJIT/issues/1166

Probably it is better to remove a link to the issue to avoid spam

in GH notifications. Or replace it with "LJ#1166".


<snipped>


  reply	other threads:[~2024-03-04 13:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 13:21 Maxim Kokryashkin via Tarantool-patches
2024-03-04 13:32 ` Sergey Bronnikov via Tarantool-patches [this message]
2024-03-04 14:13 ` Sergey Kaplun via Tarantool-patches
2024-03-06 18:16   ` Maxim Kokryashkin via Tarantool-patches
2024-03-20 15:03 ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4a261cf-0ab8-4789-b1f9-1afe99e64e44@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v2] Throw any errors before stack changes in trace stitching.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox