Re: [Tarantool-patches] [PATCH 2/2] luacheck: fix warnings in test/box-tap

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

15.01.2021 15:56, Sergey Bronnikov пишет:
> Thanks for review!
>
> On 15.01.2021 15:40, Serge Petrenko wrote:
>>
>>
>> 15.01.2021 14:22, sergeyb@tarantool.org пишет:
>>> From: Sergey Bronnikov <sergeyb@tarantool.org>
>>>
>>> Follows up #5457
>>> ---
>>>   test/box-tap/feedback_daemon.test.lua | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/test/box-tap/feedback_daemon.test.lua 
>>> b/test/box-tap/feedback_daemon.test.lua
>>> index 123033cda..8cfbf31d7 100755
>>> --- a/test/box-tap/feedback_daemon.test.lua
>>> +++ b/test/box-tap/feedback_daemon.test.lua
>>> @@ -124,8 +124,8 @@ local fh = fio.open("feedback.json")
>>>   test:ok(fh, "file is created")
>>>   local file_data = fh:read()
>>>   -- Ignore the report time. The data should be equal other than that.
>>> -feedback_save = string.gsub(feedback_save, 'time:(%d+)', 'time:0')
>>> -file_data = string.gsub(feedback_save, 'time:(%d+)', 'time:0')
>>> +feedback_save = string.gsub(feedback_save, '"time":(%d+)', 'time:0')
>>> +file_data = string.gsub(file_data, '"time":(%d+)', 'time:0')
>> Thanks for finding this typo!
>> Please also replace `time:0` with `"time":0`
>
> Sure.
>
> @@ -124,8 +124,8 @@ local fh = fio.open("feedback.json")
>  test:ok(fh, "file is created")
>  local file_data = fh:read()
>  -- Ignore the report time. The data should be equal other than that.
> -feedback_save = string.gsub(feedback_save, '"time":(%d+)', 'time:0')
> -file_data = string.gsub(file_data, '"time":(%d+)', 'time:0')
> +feedback_save = string.gsub(feedback_save, '"time":(%d+)', '"time":0')
> +file_data = string.gsub(file_data, '"time":(%d+)', '"time":0')
>  test:is(file_data, feedback_save, "data is equal")
>  fh:close()
>  fio.unlink("feedback.json")

Thanks, LGTM.

>
>>
>> Other than that LGTM.
>>
>>>   test:is(file_data, feedback_save, "data is equal")
>>>   fh:close()
>>>   fio.unlink("feedback.json")
>>> @@ -247,7 +247,7 @@ box.space.features_memtx_empty:drop()
>>>   box.space.features_memtx:drop()
>>>   box.space.features_sync:drop()
>>>   -function check_stats(stat)
>>> +local function check_stats(stat)
>>>       local sub = test:test('feedback operation stats')
>>>       sub:plan(18)
>>>       local box_stat = box.stat()
>>

-- 
Serge Petrenko